public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6sxsabresd: Use 'int' for return values
Date: Sun, 26 Jul 2015 12:13:29 +0200	[thread overview]
Message-ID: <55B4B2C9.9040604@denx.de> (raw)
In-Reply-To: <1437521842-11351-1-git-send-email-festevam@gmail.com>

Hi Fabio,

On 22/07/2015 01:37, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The variable 'ret' is used to store the value returned by pfuze_mode_init(),
> so it should be of type 'int' instead of 'unsigned int' in order to
> correctly handle negative numbers.
> 
> Fix the variable type.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx6sxsabresd/mx6sxsabresd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx6sxsabresd/mx6sxsabresd.c b/board/freescale/mx6sxsabresd/mx6sxsabresd.c
> index 2ff960e..d58a79a 100644
> --- a/board/freescale/mx6sxsabresd/mx6sxsabresd.c
> +++ b/board/freescale/mx6sxsabresd/mx6sxsabresd.c
> @@ -199,7 +199,8 @@ static struct i2c_pads_info i2c_pad_info1 = {
>  int power_init_board(void)
>  {
>  	struct pmic *p;
> -	unsigned int reg, ret;
> +	unsigned int reg;
> +	int ret;
>  
>  	p = pfuze_common_init(I2C_PMIC);
>  	if (!p)
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2015-07-26 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21 23:37 [U-Boot] [PATCH] mx6sxsabresd: Use 'int' for return values Fabio Estevam
2015-07-26 10:13 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B4B2C9.9040604@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox