From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sun, 26 Jul 2015 12:13:29 +0200 Subject: [U-Boot] [PATCH] mx6sxsabresd: Use 'int' for return values In-Reply-To: <1437521842-11351-1-git-send-email-festevam@gmail.com> References: <1437521842-11351-1-git-send-email-festevam@gmail.com> Message-ID: <55B4B2C9.9040604@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On 22/07/2015 01:37, Fabio Estevam wrote: > From: Fabio Estevam > > The variable 'ret' is used to store the value returned by pfuze_mode_init(), > so it should be of type 'int' instead of 'unsigned int' in order to > correctly handle negative numbers. > > Fix the variable type. > > Signed-off-by: Fabio Estevam > --- > board/freescale/mx6sxsabresd/mx6sxsabresd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/board/freescale/mx6sxsabresd/mx6sxsabresd.c b/board/freescale/mx6sxsabresd/mx6sxsabresd.c > index 2ff960e..d58a79a 100644 > --- a/board/freescale/mx6sxsabresd/mx6sxsabresd.c > +++ b/board/freescale/mx6sxsabresd/mx6sxsabresd.c > @@ -199,7 +199,8 @@ static struct i2c_pads_info i2c_pad_info1 = { > int power_init_board(void) > { > struct pmic *p; > - unsigned int reg, ret; > + unsigned int reg; > + int ret; > > p = pfuze_common_init(I2C_PMIC); > if (!p) > Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================