public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/12] arm: mx6: cm-fx6: map HDMI to IPU1 DI0 explicitly
Date: Sun, 26 Jul 2015 20:04:04 +0300	[thread overview]
Message-ID: <55B51304.8060703@compulab.co.il> (raw)
In-Reply-To: <1437661179-32128-2-git-send-email-nikita@compulab.co.il>

Hi Nikita,

On 07/23/15 17:19, Nikita Kiryanov wrote:
> U-Boot does not explicitly assign the display to an IPU interface. Instead, it
> relies on the power-on default of DI0.
> 
> Since the kernel reassigns HDMI display to DI1, after a warm reset the HDMI
> display no longer works in U-Boot.
> 
> Fix this by explicitly assigning HDMI to IPU1 DI0 in U-Boot.
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> ---
>  board/compulab/cm_fx6/cm_fx6.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c
> index 7a1bbaf..b500f91 100644
> --- a/board/compulab/cm_fx6/cm_fx6.c
> +++ b/board/compulab/cm_fx6/cm_fx6.c
> @@ -83,6 +83,7 @@ size_t display_count = ARRAY_SIZE(displays);
>  static void cm_fx6_setup_display(void)
>  {
>  	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
> +	struct iomuxc *const iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR;
>  	int reg;
>  
>  	enable_ipu_clock();
> @@ -90,6 +91,7 @@ static void cm_fx6_setup_display(void)
>  	reg = __raw_readl(&mxc_ccm->CCGR3);
>  	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_MASK;
>  	writel(reg, &mxc_ccm->CCGR3);
> +	clrbits_le32(&iomuxc_regs->gpr[3], MXC_CCM_CCGR3_IPU1_IPU_DI0_MASK);

I would like to see this done through a display framework of some kind...
But since there none...

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

>  }
>  #else
>  static inline void cm_fx6_setup_display(void) {}
> 

-- 
Regards,
Igor.

  parent reply	other threads:[~2015-07-26 17:04 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 14:19 [U-Boot] [PATCH 00/12] cm-fx6 and kconfig updates Nikita Kiryanov
2015-07-23 14:19 ` [U-Boot] [PATCH 01/12] arm: mx6: cm-fx6: map HDMI to IPU1 DI0 explicitly Nikita Kiryanov
2015-07-23 17:54   ` Nikolay Dimitrov
2015-07-26  8:48     ` Nikita Kiryanov
2015-07-26 13:32       ` Nikolay Dimitrov
2015-07-26 17:04   ` Igor Grinberg [this message]
2015-08-02  8:53   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 02/12] arm: mx6: cm-fx6: make it possible to not init display Nikita Kiryanov
2015-08-02  8:53   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 03/12] arm: mx6: cm-fx6: add support for displaytype env var Nikita Kiryanov
2015-07-26 17:27   ` Igor Grinberg
2015-08-02  8:53   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 04/12] arm: mx6: cm-fx6: setup hdmi only on hdmi enable Nikita Kiryanov
2015-07-26 17:28   ` Igor Grinberg
2015-08-02  8:53   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 05/12] arm: mx6: cm-fx6: move CMD configs to defconfig Nikita Kiryanov
2015-07-26 17:29   ` Igor Grinberg
2015-08-02  8:53   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 06/12] arm: mx6: cm-fx6: move cm-fx6 target under ARCH_MX6 Nikita Kiryanov
2015-07-26 17:31   ` Igor Grinberg
2015-08-02  8:54   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 07/12] arm: mx6: kconfig: don't select CPU_V7 per board Nikita Kiryanov
2015-08-02  8:54   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 08/12] arm: mx6: usb: kconfig: add USB_EHCI_MX6 kconfig option Nikita Kiryanov
2015-07-23 15:01   ` Marek Vasut
2015-07-26  8:17     ` Nikita Kiryanov
2015-07-26  9:36       ` Stefano Babic
2015-07-26 10:35         ` Marek Vasut
2015-07-26 10:50           ` Stefano Babic
2015-07-27 10:35             ` Nikita Kiryanov
2015-07-26 17:35   ` Igor Grinberg
2015-08-02  8:54   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 09/12] usb: kconfig: usb keyboard kconfig Nikita Kiryanov
2015-07-23 15:01   ` Marek Vasut
2015-07-26  8:18     ` Nikita Kiryanov
2015-07-26 17:37   ` Igor Grinberg
2015-08-02  8:54   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 10/12] usb: kconfig: create a menu for usb Nikita Kiryanov
2015-07-23 15:01   ` Marek Vasut
2015-07-23 14:19 ` [U-Boot] [PATCH 11/12] sf: kconfig: add kconfig options for spi flashes Nikita Kiryanov
2015-07-26 17:37   ` Igor Grinberg
2015-08-02  8:54   ` Stefano Babic
2015-07-23 14:19 ` [U-Boot] [PATCH 12/12] kconfig: add config option for shell prompt Nikita Kiryanov
2015-07-23 21:21   ` Tom Rini
2015-07-24  2:05     ` Masahiro Yamada
2015-07-26  8:44       ` Nikita Kiryanov
2015-07-28  7:08   ` [U-Boot] [PATCH V2 " Nikita Kiryanov
2015-07-28 15:59     ` Masahiro Yamada
2015-08-02  8:33       ` Nikita Kiryanov
2015-08-02  8:53     ` Stefano Babic
2015-08-02 11:40       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B51304.8060703@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox