[U-Boot] [PATCH v3 2/4] ARM: cache: add an empty stub function for invalidate/flush dcache

[York Sun <yorksun@freescale.com>]

On 07/26/2015 08:40 PM, Josh Wu wrote:
> Since some driver like ohci, lcd used dcache functions. But some ARM
> cpu don't implement the invalidate_dcache_range()/flush_dcache_range()
> functions.
> 
> To avoid compiling errors this patch adds an weak empty stub function
> for all ARM cpu in arch/arm/lib/cache.c.
> And ARM cpu still can implemnt its own cache functions on the cpu folder.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> 
> Changes in v3:
> - remove the same functions in the cpu/ files as they will use the weak
>   function provided in lib/cache.c
> 
> Changes in v2:
> - new added.
> 

<snip>

> diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c
> index c5ec529..f8c17cc 100644
> --- a/arch/arm/cpu/armv8/cache_v8.c
> +++ b/arch/arm/cpu/armv8/cache_v8.c
> @@ -149,14 +149,6 @@ void flush_dcache_all(void)
>  {
>  }
>  
> -void invalidate_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
> -void flush_dcache_range(unsigned long start, unsigned long stop)
> -{
> -}
> -
>  void dcache_enable(void)
>  {
>  }

Are you sure about this change? You are probably changing the wrong leg of the
#if conditional code.

York