public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 3/6] ARM: Tegra210: Add SoC code/include files for T210
Date: Mon, 27 Jul 2015 11:52:37 -0600	[thread overview]
Message-ID: <55B66FE5.7020705@wwwdotorg.org> (raw)
In-Reply-To: <1437775260-3309-4-git-send-email-twarren@nvidia.com>

On 07/24/2015 04:00 PM, Tom Warren wrote:
> All based off of Tegra124. As a Tegra210 board is brought
> up, these may change a bit to match the HW more closely,
> but probably 90% of this is identical to T124.
>
> Note that since T210 is a 64-bit build, it has no SPL
> component, and hence no cpu.c for Tegra210.

> diff --git a/arch/arm/include/asm/arch-tegra210/funcmux.h b/arch/arm/include/asm/arch-tegra210/funcmux.h

> +#include <asm/arch-tegra/funcmux.h>
> +
> +/* Configs supported by the func mux */
> +enum {
> +	FUNCMUX_DEFAULT = 0,	/* default config */
> +
> +	/* UART configs */
> +	FUNCMUX_UART1_UART1 = 0,
> +	FUNCMUX_UART4_UART4 = 0,
> +};

Since FUNCMUX_UART* aren't implemented, perhaps don't define them? you'd 
need to edit the next patch not to reference these symbols too.

Also, setup_uarts() should be fixed not to call funcmux_select() if 
uart_configs[i]==-1, since funcmux_select() will print an error if DEBUG 
is defined since those values aren't implemnted. Perhaps you could ifdef 
out the call for T210+ rather than checking the funcmux value.

This could all be done in a followon patch if you wanted.

  reply	other threads:[~2015-07-27 17:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 22:00 [U-Boot] [PATCH V3 0/6] Tegra210/P2571 initial support Tom Warren
2015-07-24 22:00 ` [U-Boot] [PATCH V3 1/6] Tegra210: Fix 64-bit build warning about save_boot_params_ret() Tom Warren
2015-07-24 22:00 ` [U-Boot] [PATCH V3 2/6] Tegra: Rework KConfig options to allow 64-bit builds (T210) Tom Warren
2015-07-24 22:00 ` [U-Boot] [PATCH V3 3/6] ARM: Tegra210: Add SoC code/include files for T210 Tom Warren
2015-07-27 17:52   ` Stephen Warren [this message]
2015-07-27 17:58     ` Tom Warren
2015-07-24 22:00 ` [U-Boot] [PATCH V3 4/6] ARM: Tegra210: Add support to common Tegra source/config files Tom Warren
2015-07-27 17:54   ` Stephen Warren
2015-07-27 17:59     ` Tom Warren
2015-07-24 22:00 ` [U-Boot] [PATCH V3 5/6] P2571: dts: Add DT file for Tegra210 P2571 board Tom Warren
2015-07-24 22:01 ` [U-Boot] [PATCH V3 6/6] T210: Add support for 64-bit T210-based " Tom Warren
2015-07-27 17:58   ` Stephen Warren
2015-07-28 19:27   ` Stephen Warren
2015-07-28 20:48     ` Tom Warren
2015-07-29 11:07     ` Thierry Reding
2015-07-29 15:57       ` Tom Warren
2015-07-29 16:09       ` Stephen Warren
2015-07-30 10:47         ` Thierry Reding
2015-07-27 18:00 ` [U-Boot] [PATCH V3 0/6] Tegra210/P2571 initial support Stephen Warren
2015-07-27 18:03   ` Tom Warren
2015-07-27 21:51   ` Tom Warren
2015-07-27 22:08     ` Tom Rini
2015-07-27 22:51       ` Tom Warren
2015-07-28  3:20         ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B66FE5.7020705@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox