From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 27 Jul 2015 11:52:37 -0600 Subject: [U-Boot] [PATCH V3 3/6] ARM: Tegra210: Add SoC code/include files for T210 In-Reply-To: <1437775260-3309-4-git-send-email-twarren@nvidia.com> References: <1437775260-3309-1-git-send-email-twarren@nvidia.com> <1437775260-3309-4-git-send-email-twarren@nvidia.com> Message-ID: <55B66FE5.7020705@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/24/2015 04:00 PM, Tom Warren wrote: > All based off of Tegra124. As a Tegra210 board is brought > up, these may change a bit to match the HW more closely, > but probably 90% of this is identical to T124. > > Note that since T210 is a 64-bit build, it has no SPL > component, and hence no cpu.c for Tegra210. > diff --git a/arch/arm/include/asm/arch-tegra210/funcmux.h b/arch/arm/include/asm/arch-tegra210/funcmux.h > +#include > + > +/* Configs supported by the func mux */ > +enum { > + FUNCMUX_DEFAULT = 0, /* default config */ > + > + /* UART configs */ > + FUNCMUX_UART1_UART1 = 0, > + FUNCMUX_UART4_UART4 = 0, > +}; Since FUNCMUX_UART* aren't implemented, perhaps don't define them? you'd need to edit the next patch not to reference these symbols too. Also, setup_uarts() should be fixed not to call funcmux_select() if uart_configs[i]==-1, since funcmux_select() will print an error if DEBUG is defined since those values aren't implemnted. Perhaps you could ifdef out the call for T210+ rather than checking the funcmux value. This could all be done in a followon patch if you wanted.