[U-Boot] [PATCH V3 3/6] ARM: Tegra210: Add SoC code/include files for T210

Tom Warren
2015-07-27T17:58:15Z

Stephen,

> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Monday, July 27, 2015 10:53 AM
> To: Tom Warren
> Cc: u-boot at lists.denx.de; Thierry Reding; Stephen Warren;
> tomcwarren3959 at gmail.com
> Subject: Re: [U-Boot] [PATCH V3 3/6] ARM: Tegra210: Add SoC code/include
> files for T210
>
> On 07/24/2015 04:00 PM, Tom Warren wrote:
> > All based off of Tegra124. As a Tegra210 board is brought up, these
> > may change a bit to match the HW more closely, but probably 90% of
> > this is identical to T124.
> >
> > Note that since T210 is a 64-bit build, it has no SPL component, and
> > hence no cpu.c for Tegra210.
>
> > diff --git a/arch/arm/include/asm/arch-tegra210/funcmux.h
> > b/arch/arm/include/asm/arch-tegra210/funcmux.h
>
> > +#include <asm/arch-tegra/funcmux.h>
> > +
> > +/* Configs supported by the func mux */ enum {
> > + FUNCMUX_DEFAULT = 0, /* default config */
> > +
> > + /* UART configs */
> > + FUNCMUX_UART1_UART1 = 0,
> > + FUNCMUX_UART4_UART4 = 0,
> > +};
>
> Since FUNCMUX_UART* aren't implemented, perhaps don't define them?
> you'd need to edit the next patch not to reference these symbols too.
I left these in so the array (uart_configs) would be filled for T210 (even though it's not used, to avoid a warning.
>
> Also, setup_uarts() should be fixed not to call funcmux_select() if
> uart_configs[i]==-1, since funcmux_select() will print an error if DEBUG is
> defined since those values aren't implemnted. Perhaps you could ifdef out the
> call for T210+ rather than checking the funcmux value.
I thought of doing that, but to me it was too messy. Since all boards call pinmux_init before this, I'll look into a follow-on patch to fix them all (i.e. none need funcmux_select now for UART setup).
>
> This could all be done in a followon patch if you wanted.

--
nvpublic