public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 16/16] apalis/colibri_t30: fix usb dm regression
Date: Mon, 27 Jul 2015 13:48:40 -0600	[thread overview]
Message-ID: <55B68B18.3050808@wwwdotorg.org> (raw)
In-Reply-To: <87134ae782f73d351e62c5e84fa29a58b4043371.1437426110.git.marcel.ziswiler@toradex.com>

On 07/20/2015 04:35 PM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Unfortunately currently both Apalis T30 as well as Colibri T30 crash
> upon starting USB host support. This is due to the following patch not
> having taken into account that our T30 device trees were defaulting to
> peripheral only mode instead of otg:
>
> commit ddb9a502d18008e845d5a8fa03ec48630fa77fb7
> dm: usb: tegra: Move most of init/uninit into a function

> diff --git a/arch/arm/dts/tegra30-colibri.dts b/arch/arm/dts/tegra30-colibri.dts

>   	/* EHCI instance 0: USB1_DP/N -> USBC_P/N */
>   	usb at 7d000000 {
>   		status = "okay";
> -		dr_mode = "peripheral";
> +		dr_mode = "otg";
>   	};

Is there SW control over driving VBUS for this port? If not, I don't 
think switching to otg is correct/possible.

It seems better to fix the crash in the code?

  reply	other threads:[~2015-07-27 19:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 22:35 [U-Boot] [PATCH v2 00/16] assortment of tegra fixes/enhancements Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 01/16] ARM: tegra: allow custom usb manufacturer/product/vendor ids/strings Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 02/16] ARM: tegra: allow reading recovery mode boot type Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 03/16] apalis/colibri_t20/t30: integrate recovery mode detection Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 04/16] colibri_t20: fix device-tree compatible node Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 05/16] colibri_t20: add lcd display support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 06/16] colibri_t20: add i2c support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 07/16] colibri_t20: disable PMIC sleep mode on low supply voltage Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 08/16] tegra: nand: fix read_byte required for proper onfi detection Marcel Ziswiler
2015-07-27 20:00   ` Scott Wood
2015-07-28  2:05     ` Marcel Ziswiler
2015-07-28  2:17       ` Scott Wood
2015-07-20 22:35 ` [U-Boot] [PATCH v2 09/16] mtd/nand/tegra: alignment workaround Marcel Ziswiler
2015-07-27 19:57   ` Scott Wood
2015-07-27 23:28     ` Simon Glass
2015-07-27 23:32       ` Scott Wood
2015-07-28  2:09         ` Marcel Ziswiler
2015-07-28  1:55     ` Marcel Ziswiler
2015-07-28  2:15       ` Scott Wood
2015-08-05 22:12       ` Marcel Ziswiler
2015-08-05 22:16         ` Scott Wood
2015-07-20 22:35 ` [U-Boot] [PATCH v2 10/16] colibri_t20: enable mtdparts support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 11/16] colibri_t20: enable ubi/ubifs support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 12/16] apalis/colibri_t20/t30: enable raw initrd support Marcel Ziswiler
2015-07-27 19:45   ` Stephen Warren
2015-07-28  1:27     ` Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 13/16] apalis/colibri_t20/t30: increase tftp blocksize Marcel Ziswiler
2015-07-27 19:46   ` Stephen Warren
2015-07-28  1:38     ` Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 14/16] apalis/colibri_t20/30: clean-up Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 15/16] colibri_t20: fix reset out pin Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 16/16] apalis/colibri_t30: fix usb dm regression Marcel Ziswiler
2015-07-27 19:48   ` Stephen Warren [this message]
2015-07-28  1:44     ` Marcel Ziswiler
2015-07-27 19:49 ` [U-Boot] [PATCH v2 00/16] assortment of tegra fixes/enhancements Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B68B18.3050808@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox