[U-Boot] [PATCH 128/172] ddr: altera: Clean up rw_mgr_*_vfifo() part 1

Marek Vasut
2015-07-27T20:51:31Z

Perform minor cleanup, fix data types and constify where applicable.
Add kerneldoc.

Signed-off-by: Marek Vasut <marex@denx.de>
---
drivers/ddr/altera/sequencer.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/drivers/ddr/altera/sequencer.c b/drivers/ddr/altera/sequencer.c
index ff11702..3d0dc59 100644
--- a/drivers/ddr/altera/sequencer.c
+++ b/drivers/ddr/altera/sequencer.c
@@ -1286,17 +1286,31 @@ static uint32_t rw_mgr_mem_calibrate_read_test_all_ranks(uint32_t group,
bit_chk, all_groups, 1);
}

-static void rw_mgr_incr_vfifo(uint32_t grp, uint32_t *v)
+/**
+ * rw_mgr_incr_vfifo() - Increase VFIFO value
+ * @grp: Read/Write group
+ * @v: VFIFO value
+ *
+ * Increase VFIFO value.
+ */
+static void rw_mgr_incr_vfifo(const u32 grp, u32 *v)
{
writel(grp, &phy_mgr_cmd->inc_vfifo_hard_phy);
(*v)++;
}

-static void rw_mgr_decr_vfifo(uint32_t grp, uint32_t *v)
+/**
+ * rw_mgr_decr_vfifo() - Decrease VFIFO value
+ * @grp: Read/Write group
+ * @v: VFIFO value
+ *
+ * Decrease VFIFO value.
+ */
+static void rw_mgr_decr_vfifo(const u32 grp, u32 *v)
{
- uint32_t i;
+ u32 i;

- for (i = 0; i < VFIFO_SIZE-1; i++)
+ for (i = 0; i < VFIFO_SIZE - 1; i++)
rw_mgr_incr_vfifo(grp, v);
}

--
2.1.4