From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Wed, 29 Jul 2015 09:56:25 -0700 Subject: [U-Boot] [PATCH] mpc85xx/T104xRDB: Remove vbank check redundant code In-Reply-To: References: <1431930663-6892-1-git-send-email-Priyanka.Jain@freescale.com> <55B6813B.2070906@freescale.com> Message-ID: <55B905B9.2050206@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/29/2015 01:31 AM, Jain Priyanka-B32167 wrote: > > >> -----Original Message----- >> From: Sun York-R58495 >> Sent: Tuesday, July 28, 2015 12:37 AM >> To: Jain Priyanka-B32167; u-boot at lists.denx.de >> Subject: Re: [PATCH] mpc85xx/T104xRDB: Remove vbank check redundant >> code >> >> >> >> On 05/17/2015 11:31 PM, Priyanka Jain wrote: >>> sw variable in checkboard function is storing vbank value which can >>> only take 4-bit value. >>> So check of sw value for if greater than 7 is redundant. >>> >>> Signed-off-by: Priyanka Jain >>> --- >>> board/freescale/t104xrdb/t104xrdb.c | 5 +---- >>> 1 files changed, 1 insertions(+), 4 deletions(-) >>> >>> diff --git a/board/freescale/t104xrdb/t104xrdb.c >>> b/board/freescale/t104xrdb/t104xrdb.c >>> index 9cd5e15..c34eea6 100644 >>> --- a/board/freescale/t104xrdb/t104xrdb.c >>> +++ b/board/freescale/t104xrdb/t104xrdb.c >>> @@ -35,10 +35,7 @@ int checkboard(void) >>> sw = CPLD_READ(flash_ctl_status); >>> sw = ((sw & CPLD_LBMAP_MASK) >> CPLD_LBMAP_SHIFT); >>> >>> - if (sw <= 7) >>> - printf("vBank: %d\n", sw); >>> - else >>> - printf("Unsupported Bank=%x\n", sw); >>> + printf("vBank: %d\n", sw); >>> >>> return 0; >>> } >>> >> >> Priyanka, >> >> 4-bit variable can still have value bigger than 7. Is there other reason you >> want to remove it? > [Jain Priyanka-B32167] Sorry, Its 3-bit variable. So cannot have value greater than 7. > CPLD_LBMAP_MASK is 0x3f and CPLD_LBMAB_SHIFT is of value 3. > So it is basically bits sw[5], sw[4], sw[3]. > If it is 3-bit value, it makes sense. Can you update the commit message? York