* [U-Boot] [PATCH][v2] mpc85xx/T104xRDB: Remove vbank check redundant code
@ 2015-07-30 4:50 Priyanka Jain
2015-07-31 15:56 ` York Sun
0 siblings, 1 reply; 2+ messages in thread
From: Priyanka Jain @ 2015-07-30 4:50 UTC (permalink / raw)
To: u-boot
sw variable in checkboard function is storing vbank value
which can only take 3-bit value.
So check of sw value for if greater than 7 is redundant.
Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
Changes for v2:
Corrected description to check is for 3-bit value
board/freescale/t104xrdb/t104xrdb.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/board/freescale/t104xrdb/t104xrdb.c b/board/freescale/t104xrdb/t104xrdb.c
index 9cd5e15..c34eea6 100644
--- a/board/freescale/t104xrdb/t104xrdb.c
+++ b/board/freescale/t104xrdb/t104xrdb.c
@@ -35,10 +35,7 @@ int checkboard(void)
sw = CPLD_READ(flash_ctl_status);
sw = ((sw & CPLD_LBMAP_MASK) >> CPLD_LBMAP_SHIFT);
- if (sw <= 7)
- printf("vBank: %d\n", sw);
- else
- printf("Unsupported Bank=%x\n", sw);
+ printf("vBank: %d\n", sw);
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH][v2] mpc85xx/T104xRDB: Remove vbank check redundant code
2015-07-30 4:50 [U-Boot] [PATCH][v2] mpc85xx/T104xRDB: Remove vbank check redundant code Priyanka Jain
@ 2015-07-31 15:56 ` York Sun
0 siblings, 0 replies; 2+ messages in thread
From: York Sun @ 2015-07-31 15:56 UTC (permalink / raw)
To: u-boot
On 07/29/2015 09:50 PM, Priyanka Jain wrote:
> sw variable in checkboard function is storing vbank value
> which can only take 3-bit value.
> So check of sw value for if greater than 7 is redundant.
>
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> ---
> Changes for v2:
> Corrected description to check is for 3-bit value
Applied to u-boot-mpc85xx master after fixing subject.
Thanks.
York
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-31 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-30 4:50 [U-Boot] [PATCH][v2] mpc85xx/T104xRDB: Remove vbank check redundant code Priyanka Jain
2015-07-31 15:56 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox