[U-Boot] [PATCH V2 12/12] kconfig: add config option for shell prompt

Nikita Kiryanov
2015-08-02T08:33:27Z

On Wed, Jul 29, 2015 at 12:59:00AM +0900, Masahiro Yamada wrote:
> 2015-07-28 16:08 GMT+09:00 Nikita Kiryanov <nikita@compulab.co.il>:
> > Add option to set shell prompt string from menuconfig and migrate
> > boards globally.
> >
> > The migration is done as follows:
> > - Boards that explicitly and unconditionally set CONFIG_SYS_PROMPT had the
> > entry moved to their defconfig files.
> > - Boards that defined some kind of #ifdef logic which selects the
> > CONFIG_SYS_PROMPT (for example qemu-mips) got an #undef CONFIG_SYS_PROMPT
> > right before the #ifdef logic and were left alone.
> > - This change forces CONFIG_SYS_PROMPT to be a per board decision, and thus
> > CONFIG_SYS_PROMPT was removed from all <soc>_common.h and <arch>_common.h
> > files. This results in a streamlined default value across platforms, and
> > includes the following files: spear-common, sunxi-common, mv-common,
> > ti_armv7_common, tegra-common, at91-sama5_common, and zynq-common.
> > - Boards that relied on <arch/soc>_common.h values of CONFIG_SYS_PROMPT were
> > not updated in their respective defconfig files under the assumption that
> > since they did not explicitly define a value, they're fine with whatever
> > the default is.
> > - On the other hand, boards that relied on a value defined in some
> > <boards>_common.h file such as woodburn_common, rpi-common,
> > bur_am335x_common, ls2085a_common, siemens_am33x_common, and
> > omap3_evm_common, had their values moved to the respective defconfig files.
> > - The define V_PROMPT was removed, since it is not used anywhere except for
> > assigning a value for CONFIG_SYS_PROMPT.
> >
> > Cc: Tom Rini <trini@konsulko.com>
> > Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Igor Grinberg <grinberg@compulab.co.il>
> > Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> > ---
> > Changes in V2:
> > - Migrate boards globally (compile tested with buildman on arm and
> > powerpc)
> > - Change default value to "=> "
> > - V_PROMPT define removed as part of the migration
> >
>
> > diff --git a/configs/T1023RDB_NAND_defconfig b/configs/T1023RDB_NAND_defconfig
> > index 3ee42d6..af44f87 100644
> > --- a/configs/T1023RDB_NAND_defconfig
> > +++ b/configs/T1023RDB_NAND_defconfig
> > @@ -6,3 +6,4 @@ CONFIG_SYS_EXTRA_OPTIONS="PPC_T1023,T1023RDB,RAMBOOT_PBL,SPL_FSL_PBL,NAND"
> > # CONFIG_CMD_IMLS is not set
> > # CONFIG_CMD_FLASH is not set
> > CONFIG_SPI_FLASH=y
> > +CONFIG_SYS_PROMPT="=> "
>
>
> This is the same as the default. It should not appear in a defconfig.

I'll take care of it in a V3...

>
> It is not sorted by savedefconfig, either.
>
> tools/moveconfig.py exists to do such things automatically.

OK I'll use it next time.

>
> --
> Best Regards
> Masahiro Yamada
>