public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] udoo: Switch to SPL support
Date: Mon, 03 Aug 2015 15:59:22 +0200	[thread overview]
Message-ID: <55BF73BA.20704@denx.de> (raw)
In-Reply-To: <CAOMZO5ApnsqUhfi=n5Yxg69mNxUxT6Kdz-qjZe6GJ6Mb+2=Rsg@mail.gmail.com>

On 03/08/2015 15:19, Fabio Estevam wrote:
> Hi Peter,
> 
> On Mon, Aug 3, 2015 at 7:49 AM, vpeter4 <peter.vicman@gmail.com> wrote:
>> Currently we need to build one U-boot image for each of the udoo
>> variants: quad and dual-lite.
>>
>> By switching to SPL we can support all two variants with a single binary.
>>
>> Based on the SPL for wandboard.
>>
>> Tested with OpenELEC (Open Embedded Linux Entertainment Center)
>> on both boards.
> 
> Looks very good. Great job! Just some minor issues:
> 
>> Signed-off-by: vpeter4 <peter.vicman@gmail.com>
> 
> The preferred form is to pass the real name in the Signed-off tag, so
> you should do:
> 
> Signed-off-by: Peter Vicman <peter.vicman@gmail.com>
> 
>> Cc: Fabio Estevam <fabio.estevam@gmail.com>
> 
> That's not a valid email address. You can use either
> festevam at gmail.com or fabio.estevam at freescale.com
> 
>> Cc: Stefano Babic <sbabic@denx.de>
> 
> Maybe Stefano could fix these two small issues while applying your patch.

Yes, thanks for note this.

I will fix them by applying, no need to repost.

> 
> With these fixes in place:
> 
> Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
> 

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2015-08-03 13:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 10:49 [U-Boot] [PATCH] udoo: Switch to SPL support vpeter4
2015-08-03 13:09 ` Stefano Babic
2015-08-03 13:19 ` Fabio Estevam
2015-08-03 13:59   ` Stefano Babic [this message]
2015-08-04 18:42 ` Robert Nelson
2015-08-04 18:50   ` Otavio Salvador
  -- strict thread matches above, loose matches on Subject: below --
2015-08-03 14:09 Peter Vicman
2015-08-04 19:53 Peter Vicman
2015-08-05  7:40 Peter Vicman
2015-08-05  7:57 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BF73BA.20704@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox