[U-Boot] [PATCH] Do not mux and setup SPI if disabled in the config

Stefan Roese
2015-08-05T08:36:33Z

Hi Clemens,

On 05.08.2015 10:17, Clemens Gruber wrote:
> On Wed, Aug 05, 2015 at 10:05:10AM +0200, Stefan Roese wrote:
>> How about this patch:
>>
>> diff --git a/board/tqc/tqma6/tqma6.c b/board/tqc/tqma6/tqma6.c
>> index 29db838..345930f 100644
>> --- a/board/tqc/tqma6/tqma6.c
>> +++ b/board/tqc/tqma6/tqma6.c
>> @@ -28,6 +28,13 @@
>>
>> #include "tqma6_bb.h"
>>
>> +#ifndef CONFIG_SF_DEFAULT_BUS
>> +#define CONFIG_SF_DEFAULT_BUS 0
>> +#endif
>> +#ifndef CONFIG_SF_DEFAULT_CS
>> +#define CONFIG_SF_DEFAULT_CS 0
>> +#endif
>>
>> Does this work for you?
>
> This should work, but wouldn't it be cleaner to just exclude the SPI parts?
> Why add 7 LOC when 4 LOC are enough to exclude the SPI parts? Besides that, it
> reduces the binary size.

The binary size should be the same (I didn't check this). The linker
should remove the not referenced functions / variables.

As for the added 7 LOC, Jagans suggestion to include "spi_flash.h"
should also work instead. This seems to be a nice solution for me that
doesn't add any new #ifdef's to the code.

Thanks,
Stefan