[U-Boot] [PATCH] Do not mux and setup SPI if disabled in the config

Clemens Gruber
2015-08-05T08:33:34Z

On Wed, Aug 05, 2015 at 01:46:42PM +0530, Jagan Teki wrote:
> On 5 August 2015 at 13:35, Stefan Roese <sr@denx.de> wrote:
> > How about this patch:
> >
> > diff --git a/board/tqc/tqma6/tqma6.c b/board/tqc/tqma6/tqma6.c
> > index 29db838..345930f 100644
> > --- a/board/tqc/tqma6/tqma6.c
> > +++ b/board/tqc/tqma6/tqma6.c
> > @@ -28,6 +28,13 @@
> >
> > #include "tqma6_bb.h"
> >
> > +#ifndef CONFIG_SF_DEFAULT_BUS
> > +#define CONFIG_SF_DEFAULT_BUS 0
> > +#endif
> > +#ifndef CONFIG_SF_DEFAULT_CS
> > +#define CONFIG_SF_DEFAULT_CS 0
> > +#endif
>
> Why would need this - it's already part of spi_flash.h

I am also wondering about commit f85764cc1f6ab01ffc60dd78de9c4de4cff2b5ce, which
defines CONFIG_SPI_FLASH in the WRU4 defconfig file, even though it does not
need SPI flash support, just to work around undefined reference errors regarding
spi_flash_free, etc.

Couldn't those workarounds be avoided by excluding the SPI parts via ifdefs, as
I did in my patch today?

>
> >
> > Does this work for you?
>
> thanks!
> --
> Jagan | openedev.

Thanks,
Clemens