public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 2/2] ARM: tegra: Add p2371-0000 board
Date: Wed, 05 Aug 2015 11:04:48 -0600	[thread overview]
Message-ID: <55C24230.6020108@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ1AHyKb-HPC9NY-3OEcj=yzkJnYHa2WLXVScW1Zpz9s2w@mail.gmail.com>

On 08/05/2015 08:39 AM, Simon Glass wrote:
> Hi Stephen,
>
> On 31 July 2015 at 17:21, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> P2371-0000 is a P2581 or P2530 CPU board married to a P2595 I/O
>> board. The combination contains SoC, DRAM, eMMC, SD card slot,
>> HDMI, USB micro-B port, Ethernet via USB3, USB3 host port, SATA,
>> a GPIO expansion header, and an analog audio jack.

>> diff --git a/include/configs/p2371-0000.h b/include/configs/p2371-0000.h

>> +/* enable PMIC */
>> +#define CONFIG_MAX77620_POWER
>
> That should go in Kconfig.
>
>> +
>> +#include "tegra210-common.h"
>> +
>> +/* High-level configuration options */
>> +#define V_PROMPT                       "Tegra210 (P2371-0000) # "
>> +#define CONFIG_TEGRA_BOARD_STRING      "NVIDIA P2371-0000"
>> +
>> +/* Board-specific serial config */
>> +#define CONFIG_SERIAL_MULTI
>
> Is that used?

I don't think either of MAX77620_POWER or SERIAL_MULTI exist any more. 
I'll drop those #defines, and send a patch to clean up existing files 
that still define them.

  reply	other threads:[~2015-08-05 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 23:21 [U-Boot] [PATCH V3 1/2] ARM: tegra: Add e2220-1170 board Stephen Warren
2015-07-31 23:21 ` [U-Boot] [PATCH V3 2/2] ARM: tegra: Add p2371-0000 board Stephen Warren
2015-08-05 14:39   ` Simon Glass
2015-08-05 17:04     ` Stephen Warren [this message]
2015-08-05 14:39 ` [U-Boot] [PATCH V3 1/2] ARM: tegra: Add e2220-1170 board Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C24230.6020108@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox