[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[Vladimir Zapolskiy]

The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX
MAC to some specified phy by phy id, by chance the single user of
lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may
have non-zero CONFIG_PHY_ADDR value, fix it.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 drivers/net/lpc32xx_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c
index 72451a9..6033392 100644
--- a/drivers/net/lpc32xx_eth.c
+++ b/drivers/net/lpc32xx_eth.c
@@ -630,7 +630,7 @@ int lpc32xx_eth_initialize(bd_t *bis)
 	eth_register(dev);
 
 #if defined(CONFIG_PHYLIB)
-	lpc32xx_eth_phylib_init(dev, 0);
+	lpc32xx_eth_phylib_init(dev, CONFIG_PHY_ADDR);
 #elif defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
 	miiphy_register(dev->name, mii_reg_read, mii_reg_write);
 #endif
-- 
2.1.4

[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[Albert ARIBAUD]

Bonjour Vladimir,

Le Mon, 29 Jun 2015 03:35:12 +0300, Vladimir Zapolskiy <vz@mleia.com> a
?crit :

> The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX
> MAC to some specified phy by phy id, by chance the single user of
> lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may
> have non-zero CONFIG_PHY_ADDR value, fix it.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  drivers/net/lpc32xx_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c
> index 72451a9..6033392 100644
> --- a/drivers/net/lpc32xx_eth.c
> +++ b/drivers/net/lpc32xx_eth.c
> @@ -630,7 +630,7 @@ int lpc32xx_eth_initialize(bd_t *bis)
>  	eth_register(dev);
>  
>  #if defined(CONFIG_PHYLIB)
> -	lpc32xx_eth_phylib_init(dev, 0);
> +	lpc32xx_eth_phylib_init(dev, CONFIG_PHY_ADDR);
>  #elif defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
>  	miiphy_register(dev->name, mii_reg_read, mii_reg_write);
>  #endif

Acked-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr>

Cordialement,
Albert ARIBAUD
3ADEV

[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[LEMIEUX, SYLVAIN]

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
> Sent: 29-Jun-15 4:25 AM
>
> Bonjour Vladimir,
>
> Le Mon, 29 Jun 2015 03:35:12 +0300, Vladimir Zapolskiy <vz@mleia.com> a
> ?crit :
>
> > The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX
> > MAC to some specified phy by phy id, by chance the single user of
> > lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may
> > have non-zero CONFIG_PHY_ADDR value, fix it.
> >
> > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> > ---
> >  drivers/net/lpc32xx_eth.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c
> > index 72451a9..6033392 100644
> > --- a/drivers/net/lpc32xx_eth.c
> > +++ b/drivers/net/lpc32xx_eth.c
> > @@ -630,7 +630,7 @@ int lpc32xx_eth_initialize(bd_t *bis)
> >     eth_register(dev);
> >
> >  #if defined(CONFIG_PHYLIB)
> > -   lpc32xx_eth_phylib_init(dev, 0);
> > +   lpc32xx_eth_phylib_init(dev, CONFIG_PHY_ADDR);
> >  #elif defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
> >     miiphy_register(dev->name, mii_reg_read, mii_reg_write);
> >  #endif
>
> Acked-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr>
>
> Cordialement,
> Albert ARIBAUD
> 3ADEV

Tested with a PHY setup at an address different than 0;
Tested-by: Sylvain Lemieux <slemieux@tycoint.com>

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

________________________________

This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.

[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[Joe Hershberger]

Hi Vladimir,

On Sun, Jun 28, 2015 at 7:35 PM, Vladimir Zapolskiy <vz@mleia.com> wrote:
> The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX
> MAC to some specified phy by phy id, by chance the single user of
> lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may
> have non-zero CONFIG_PHY_ADDR value, fix it.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

I'll pull this into u-boot-net/next, Thanks!
-Joe

[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[Vladimir Zapolskiy]

Hi Joe,

On 29.06.2015 23:37, Joe Hershberger wrote:
> Hi Vladimir,
> 
> On Sun, Jun 28, 2015 at 7:35 PM, Vladimir Zapolskiy <vz@mleia.com> wrote:
>> The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX
>> MAC to some specified phy by phy id, by chance the single user of
>> lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may
>> have non-zero CONFIG_PHY_ADDR value, fix it.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
> 
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> I'll pull this into u-boot-net/next, Thanks!
> -Joe
> 

ping.

With best wishes,
Vladimir

[U-Boot] [PATCH] net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id

[Joe Hershberger]

Hi Vladimir,

On Sun, Jun 28, 2015 at 7:35 PM, Vladimir Zapolskiy <vz@mleia.com> wrote:
> The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX
> MAC to some specified phy by phy id, by chance the single user of
> lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may
> have non-zero CONFIG_PHY_ADDR value, fix it.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>

Applied to u-boot-net, thanks!
-Joe