public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vitaly Andrianov <vitalya@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ti_armv7_common: enable setexpr
Date: Thu, 6 Aug 2015 12:35:11 -0400	[thread overview]
Message-ID: <55C38CBF.3000600@ti.com> (raw)
In-Reply-To: <20150806153125.GK25532@bill-the-cat>



On 08/06/2015 11:31 AM, Tom Rini wrote:
> On Thu, Aug 06, 2015 at 10:08:59AM -0500, Nishanth Menon wrote:
>> On 08/06/2015 10:04 AM, Tom Rini wrote:
>>> On Thu, Aug 06, 2015 at 09:48:27AM -0500, Nishanth Menon wrote:
>>>
>>>> This allows us to do basic math in hush shell. For example:
>>>> U-Boot# r1=10
>>>> U-Boot# r2=20
>>>> U-Boot# setexpr.l r3 $r1 + $r2
>>>> U-Boot# echo $r3
>>>> 30
>>>>
>>>> Reported-by: Vitaly Andrianov <vitalya@ti.com>
>>>> Suggested-by: Tom Rini <trini@ti.com>
>>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>>
>>> This needs to be done in the configs/ files now instead as we have
>>> CMD_EXPR there.  In fact I'm not sure right now which would win, the
>>> define here or the disable currently in the config files :)
>>>
>> yeah, I do many defconfigs define CONFIG_CMD_SETEXPR..
>>
>> We dont have a common config file there(similar to ti_armv7_common) ..
>> we'd have to introduce this for every board config then... is'nt that
>> in-efficient?
>
> Much like the kernel we try and pick sensible defaults.  In this case
> you'd be removing a line from the defconfig files.
>
> But you're not the first to suggest that something better could be done
> here and maybe further down the line we'll play with the upstream tools
> for merging defconfig snippets so that we could have some common ones
> pulled together.
>
I just curious whether setexpr.l will work with 64bit variable, which
required to represent initrd address with LPAE enabled. Does the
setexpr have uint_64_t version?

      reply	other threads:[~2015-08-06 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 14:48 [U-Boot] [PATCH] ti_armv7_common: enable setexpr Nishanth Menon
2015-08-06 15:04 ` Tom Rini
2015-08-06 15:08   ` Nishanth Menon
2015-08-06 15:31     ` Tom Rini
2015-08-06 16:35       ` Vitaly Andrianov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C38CBF.3000600@ti.com \
    --to=vitalya@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox