public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/3] mmc: Calculate dwmmc FIFO threshold size if not provided
Date: Fri, 07 Aug 2015 13:26:40 +0900	[thread overview]
Message-ID: <55C43380.70208@samsung.com> (raw)
In-Reply-To: <1438913789-22308-3-git-send-email-sjg@chromium.org>

Hi,

Could you fix the prefix of subject with dw_mmc? :)
Anyway..looks good to me.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

On 08/07/2015 11:16 AM, Simon Glass wrote:
> We can calculate this. Add code to do this if it is not provided.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v4: None
> 
>  drivers/mmc/dw_mmc.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index a034c3f..cce2a5d 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -355,9 +355,15 @@ static int dwmci_init(struct mmc *mmc)
>  	dwmci_writel(host, DWMCI_IDINTEN, 0);
>  	dwmci_writel(host, DWMCI_BMOD, 1);
>  
> -	if (host->fifoth_val) {
> -		dwmci_writel(host, DWMCI_FIFOTH, host->fifoth_val);
> +	if (!host->fifoth_val) {
> +		uint32_t fifo_size;
> +
> +		fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
> +		fifo_size = ((fifo_size & RX_WMARK_MASK) >> RX_WMARK_SHIFT) + 1;
> +		host->fifoth_val = MSIZE(0x2) | RX_WMARK(fifo_size / 2 - 1) |
> +				TX_WMARK(fifo_size / 2);
>  	}
> +	dwmci_writel(host, DWMCI_FIFOTH, host->fifoth_val);
>  
>  	dwmci_writel(host, DWMCI_CLKENA, 0);
>  	dwmci_writel(host, DWMCI_CLKSRC, 0);
> 

  reply	other threads:[~2015-08-07  4:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  2:16 [U-Boot] [PATCH v4 1/3] mmc: dw_mmc: Avoid using printf() for errors Simon Glass
2015-08-07  2:16 ` [U-Boot] [PATCH v4 2/3] mmc: dw_mmc: Support bypass mode with the get_mmc_clk() method Simon Glass
2015-08-07  2:51   ` Marek Vasut
2015-08-07  2:54     ` Simon Glass
2015-08-07  2:58       ` Marek Vasut
2015-08-07  3:00         ` Simon Glass
2015-08-07  3:07           ` Marek Vasut
2015-08-07  5:51             ` Jaehoon Chung
2015-08-12 13:04             ` Simon Glass
2015-08-12 13:48               ` Marek Vasut
2015-08-12 13:51                 ` Simon Glass
2015-08-12 13:53                   ` Marek Vasut
2015-08-12 13:55                     ` Simon Glass
2015-08-12 14:40                       ` Marek Vasut
2015-08-12 21:09                         ` Simon Glass
2015-08-12 22:11                           ` Marek Vasut
2015-08-12  7:39   ` Pantelis Antoniou
2015-08-12  8:55     ` Marek Vasut
2015-08-07  2:16 ` [U-Boot] [PATCH v4 3/3] mmc: Calculate dwmmc FIFO threshold size if not provided Simon Glass
2015-08-07  4:26   ` Jaehoon Chung [this message]
2015-08-12  7:40   ` Pantelis Antoniou
2015-08-07  4:22 ` [U-Boot] [PATCH v4 1/3] mmc: dw_mmc: Avoid using printf() for errors Jaehoon Chung
2015-08-12  7:37 ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C43380.70208@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox