From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Fri, 07 Aug 2015 09:19:22 +0200 Subject: [U-Boot] [PATCH] imx: mx6 move TARGET_xx Kconfig option to mx6 specific Kconfig file In-Reply-To: <20150807011744.GB15528@shlinux2> References: <1438839833-6974-1-git-send-email-Peng.Fan@freescale.com> <55C32A18.4060808@web.de> <20150807011744.GB15528@shlinux2> Message-ID: <55C45BFA.5020703@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07.08.2015 03:17, Peng Fan wrote: > On Thu, Aug 06, 2015 at 11:34:16AM +0200, Soeren Moch wrote: >> On 08/06/15 07:43, Peng Fan wrote: >>> Move TARGET_xx Kconfig option based on mx6 to arch/arm/cpu/armv7/mx6/Kconfig. >>> Add enable "CONFIG_ARCH_MX6" for boards based on mx6. >>> Then we can choose target boards using "make ARCH=arm menuconfig" >>> with ARCH_MX6 defined. >>> >>> If using original way, we have no chance to enable ARCH_MX6 when >>> "make menuconfig". Even define CONFIG_ARCH_MX6=y in xx_defconfig, >>> kconfig will complains "arch/../configs/platinum_titanium_defconfig:3: >>> warning: override: TARGET_PLATINUM_TITANIUM changes choice state" >>> >>> Signed-off-by: Peng Fan >>> Cc: Stefano Babic >>> Cc: Heiko Schocher >>> Cc: Tim Harvey >>> Cc: Eric B?nard >>> Cc: Fabio Estevam >>> Cc: Eric Nelson >>> Cc: Marek Vasut >>> Cc: Christian Gmeiner >>> Cc: Stefan Roese >>> Cc: Soeren Moch >>> Cc: Otavio Salvador >>> Signed-off-by: Peng Fan >>> --- >> [...] >>> index dce7ffc..b7481e7 100644 >>> --- a/arch/arm/cpu/armv7/mx6/Kconfig >>> +++ b/arch/arm/cpu/armv7/mx6/Kconfig >>> @@ -46,6 +46,113 @@ config TARGET_SECOMX6 >>> config TARGET_TQMA6 >>> bool "TQ Systems TQMa6 board" >>> >>> +config TARGET_UDOO >>> + bool "Support udoo" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_OT1200 >>> + bool "Bachmann OT1200" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_WANDBOARD >>> + bool "Support wandboard" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_WARP >>> + bool "Support WaRP" >>> + select CPU_V7 >>> + >>> +config TARGET_MX6CUBOXI >>> + bool "Support Solid-run mx6 boards" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_MX6SLEVK >>> + bool "Support mx6slevk" >>> + select CPU_V7 >>> + >>> +config TARGET_MX6SXSABRESD >>> + bool "Support mx6sxsabresd" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + select DM >>> + select DM_THERMAL >>> + >>> +config TARGET_MX6UL_14X14_EVK >>> + bool "Support mx6ul_14x14_evk" >>> + select CPU_V7 >>> + select DM >>> + select DM_THERMAL >>> + select SUPPORT_SPL >>> + >>> +config TARGET_MX6QARM2 >>> + bool "Support mx6qarm2" >>> + select CPU_V7 >>> + >>> +config TARGET_MX6QSABREAUTO >>> + bool "Support mx6qsabreauto" >>> + select CPU_V7 >>> + select DM >>> + select DM_THERMAL >>> + >>> +config TARGET_MX6SABRESD >>> + bool "Support mx6sabresd" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + select DM >>> + select DM_THERMAL >>> + >>> +config TARGET_GW_VENTANA >>> + bool "Support gw_ventana" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_TITANIUM >>> + bool "Support titanium" >>> + select CPU_V7 >>> + >>> +config TARGET_NITROGEN6X >>> + bool "Support nitrogen6x" >>> + select CPU_V7 >>> + >>> +config TARGET_CGTQMX6EVAL >>> + bool "Support cgtqmx6eval" >>> + select CPU_V7 >>> + >>> +config TARGET_EMBESTMX6BOARDS >>> + bool "Support embestmx6boards" >>> + select CPU_V7 >>> + >>> +config TARGET_ARISTAINETOS >>> + bool "Support aristainetos" >>> + select CPU_V7 >>> + >>> +config TARGET_ARISTAINETOS2 >>> + bool "Support aristainetos2" >>> + select CPU_V7 >>> + >>> +config TARGET_KOSAGI_NOVENA >>> + bool "Support Kosagi Novena" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_TBS2910 >>> + bool "Support tbs2910" >>> + select CPU_V7 >>> + >>> +config TARGET_PLATINUM_PICON >>> + bool "Support platinum-picon" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> +config TARGET_PLATINUM_TITANIUM >>> + bool "Support platinum-titanium" >>> + select CPU_V7 >>> + select SUPPORT_SPL >>> + >>> endchoice >>> >>> config SYS_SOC >> [...] >> >> [...] >> Also I think we don't need "Support" in the board select options, unfortunately this >> is already not consistent in arch/arm/cpu/armv7/mx6/Kconfig . > > Would you please more clear about this? I can not follow you. > The reason I did this patch is that we can not select ARCH_MX6, > if all the board target options in arch/arm/Kconfig. Since we can not select > ARCH_MX6, the Kconfig options in arch/arm/cpu/armv7/mx6/Kconfig will not effect. > Peng, Sorry for being unclear here. In your patch you add several options in arch/arm/cpu/armv7/mx6/Kconfig under "MX6 board select". Some of these options are named "Support " (e.g. "Support udoo"), while others are simply called "" (e.g. "Bachmann OT1200"). I would prefer the simple "" naming style for all options and remove the word "Support" from all description strings. But this is only my personal opinion and a minor cosmetic change. Regards, Soeren