public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] arm: socfpga: scan: Clean up horrible macros
Date: Fri, 7 Aug 2015 15:40:18 -0500	[thread overview]
Message-ID: <55C517B2.9060406@opensource.altera.com> (raw)
In-Reply-To: <1438611733-7373-3-git-send-email-marex@denx.de>



On 8/3/15 9:22 AM, Marek Vasut wrote:
> Clean up the horrible macros present in the scan_manager.h . Firstly,
> the function scan_mgr_io_scan_chain_prg() is static, yet all the macros
> are used only within it, thus there is no point in having them in the
> header file. Moreover, the macros are just making the code much less
> readable, so remove them instead.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
>  arch/arm/mach-socfpga/include/mach/scan_manager.h | 42 --------------------
>  arch/arm/mach-socfpga/scan_manager.c              | 47 ++++++++---------------
>  2 files changed, 17 insertions(+), 72 deletions(-)
> 

Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>

Thanks,
Dinh

  reply	other threads:[~2015-08-07 20:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 14:22 [U-Boot] [PATCH 1/6] arm: socfpga: scan: Clean up scan_chain_engine_is_idle() Marek Vasut
2015-08-03 14:22 ` [U-Boot] [PATCH 2/6] arm: socfpga: scan: Introduce generic JTAG accessor Marek Vasut
2015-08-07 20:27   ` Dinh Nguyen
2015-08-03 14:22 ` [U-Boot] [PATCH 3/6] arm: socfpga: scan: Clean up horrible macros Marek Vasut
2015-08-07 20:40   ` Dinh Nguyen [this message]
2015-08-03 14:22 ` [U-Boot] [PATCH 4/6] arm: socfpga: scan: Factor out IO chain programming Marek Vasut
2015-08-07 20:52   ` Dinh Nguyen
2015-08-03 14:22 ` [U-Boot] [PATCH 5/6] arm: socfpga: scan: Add code to get FPGA ID Marek Vasut
2015-08-03 14:22 ` [U-Boot] [PATCH 6/6] arm: socfpga: misc: Add support for printing FPGA type Marek Vasut
2015-08-05 19:57 ` [U-Boot] [PATCH 1/6] arm: socfpga: scan: Clean up scan_chain_engine_is_idle() Marek Vasut
2015-08-07 20:26 ` Dinh Nguyen
2015-08-08 12:14   ` Marek Vasut
2015-08-08 12:15 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C517B2.9060406@opensource.altera.com \
    --to=dinguyen@opensource.altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox