From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 07/16] common/cmd_ethsw: Add generic commands for Ethernet Switches
Date: Fri, 7 Aug 2015 15:58:21 -0700 [thread overview]
Message-ID: <55C5380D.6070507@freescale.com> (raw)
In-Reply-To: <CANr=Z=Yvm-VgP92RQD1Re6gsoujMR0qiAE10C-zWZ76G8uMaEw@mail.gmail.com>
On 08/07/2015 01:18 PM, Joe Hershberger wrote:
<snip>
>> + }
>> +
>> + /* if all our optional command's keywords perfectly match an
>> + * optional pattern, then we can move to the next defined
>> + * keywords in our command; remember the one that matched the
>> + * greatest number of keywords
>> + */
>
> Improper comment format. Please make sure you always run your patches
> through checkpatch.pl. I recommend using patman!
>
Joe,
Do you mean the multiple-line comment should start from the second line? I can
change it when I merge the patch.
Checkpatch/patman doesn't complain about this format.
York
next prev parent reply other threads:[~2015-08-07 22:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 13:55 [U-Boot] [PATCH v3 04/16] drivers/net/vsc9953: Fix missing reserved register Codrin Ciubotariu
2015-07-24 13:55 ` [U-Boot] [PATCH v3 05/16] include/bitfield: Add new bitfield operations Codrin Ciubotariu
2015-08-07 20:17 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 06/16] drivers/net/vsc9953: Add default configuration for VSC9953 L2 Switch Codrin Ciubotariu
2015-08-07 20:17 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 07/16] common/cmd_ethsw: Add generic commands for Ethernet Switches Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-08-07 22:58 ` York Sun [this message]
2015-08-10 5:47 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 08/16] drivers/net/vsc9953: Use the generic Ethernet Switch parser Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 09/16] drivers/net/vsc9953: Add command to show/clear port counters Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 10/16] drivers/net/vsc9953: Add commands to enable/disable HW learning Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 11/16] net/eth.c: Add function to validate a MAC address Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-08-08 0:30 ` York Sun
2015-08-10 8:44 ` Codrin Constantin Ciubotariu
2015-08-10 19:41 ` York Sun
2015-08-10 19:57 ` Joe Hershberger
2015-08-10 20:03 ` York Sun
2015-08-10 20:05 ` Joe Hershberger
2015-08-10 20:45 ` York Sun
2015-08-12 19:58 ` York Sun
2015-08-13 7:33 ` Codrin Constantin Ciubotariu
2015-08-13 15:42 ` Codrin Constantin Ciubotariu
2015-08-13 15:54 ` York Sun
2015-08-14 8:28 ` Codrin Constantin Ciubotariu
2015-08-14 17:59 ` York Sun
2015-08-17 14:37 ` Joe Hershberger
2015-08-17 15:17 ` York Sun
2015-08-19 7:21 ` Codrin Constantin Ciubotariu
2015-07-24 13:55 ` [U-Boot] [PATCH v3 12/16] drivers/net/vsc9953: Add commands to manipulate the FDB for VSC9953 Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 13/16] drivers/net/vsc9953: Add VLAN commands " Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 14/16] drivers/net/vsc9953: Add command for shared/private VLAN learning Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 15/16] drivers/net/vsc9953: Add commands for VLAN ingress filtering Codrin Ciubotariu
2015-08-07 20:18 ` Joe Hershberger
2015-07-24 13:55 ` [U-Boot] [PATCH v3 16/16] drivers/net/vsc9953: Add GPL-2.0+ SPDX-License-Identifier Codrin Ciubotariu
2015-08-07 20:19 ` Joe Hershberger
2015-08-07 20:17 ` [U-Boot] [PATCH v3 04/16] drivers/net/vsc9953: Fix missing reserved register Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C5380D.6070507@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox