From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Mon, 10 Aug 2015 07:16:02 +0200
Subject: [U-Boot] [PATCH 2/3] usb: gadget: at91_udc: add support for
	at91_udc
In-Reply-To: <20150721085932.698de418@amdc2363>
References: <1434372182-8967-1-git-send-email-hs@denx.de>
 <1434372182-8967-3-git-send-email-hs@denx.de>
 <20150721085932.698de418@amdc2363>
Message-ID: <55C83392.5090405@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Luaksz,

Am 21.07.2015 um 08:59 schrieb Lukasz Majewski:
> Hi Heiko,
>
>> ported from linux:
>>
>> b2ba27a5c56ff: usb: gadget: at91_udc: move prepare clk into process
>> context
>>
>
> IMHO, presented above description is not enough. I'd prefer to see one
> patch which adds the code from linux - including the exact commit
> message.

Ok, I change this.

> Then, u-boot specific adjustments should be applied in a separate patch.
>
> In that way you would:
> 1. Avoid #ifdef __UBOOT__

Hmm.. I change this, but I do not hate this define, if I debug in the
Code I immediately see, if it is linux code, or U-Boot specific ...
we had such a discussion also on other places ... maybe we need
here a decision, if we remove this define complete?

> 2. Make the process of updating code easier

I soon post a v2, just did a rebase and found some compile errors
for the smartweb board ...

bye,
Heiko
>
>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>> checkpatch detects a lot of errors, but as this code is copied
>> from linux, I tend to not fix them, so later updates with
>> linux code is easier.
>>
>>   drivers/usb/gadget/Makefile   |    1 +
>>   drivers/usb/gadget/at91_udc.c | 2203
>> +++++++++++++++++++++++++++++++++++++++++
>> drivers/usb/gadget/at91_udc.h |  171 ++++
>> include/linux/usb/at91_udc.h  |   20 + 4 files changed, 2395
>> insertions(+) create mode 100644 drivers/usb/gadget/at91_udc.c
>>   create mode 100644 drivers/usb/gadget/at91_udc.h
>>   create mode 100644 include/linux/usb/at91_udc.h
>>
>> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
>> index 70bb550..22323fa 100644
>> --- a/drivers/usb/gadget/Makefile
>> +++ b/drivers/usb/gadget/Makefile
>> @@ -10,6 +10,7 @@ obj-$(CONFIG_USB_ETHER) += epautoconf.o config.o
>> usbstring.o
>>   # new USB gadget layer dependencies
>>   ifdef CONFIG_USB_GADGET
>> +obj-$(CONFIG_USB_GADGET_AT91) += at91_udc.o
>>   obj-$(CONFIG_USB_GADGET_ATMEL_USBA) += atmel_usba_udc.o
>>   obj-$(CONFIG_USB_GADGET_S3C_UDC_OTG) += s3c_udc_otg.o
>>   obj-$(CONFIG_USB_GADGET_S3C_UDC_OTG_PHY) += s3c_udc_otg_phy.o
>> diff --git a/drivers/usb/gadget/at91_udc.c
>> b/drivers/usb/gadget/at91_udc.c new file mode 100644
>> index 0000000..f4ae13b
>> --- /dev/null
>> +++ b/drivers/usb/gadget/at91_udc.c
>> @@
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany