From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 06/11] arm: rpi: Enable device tree control for Rasberry Pi
Date: Mon, 10 Aug 2015 21:47:09 -0600 [thread overview]
Message-ID: <55C9703D.9040200@wwwdotorg.org> (raw)
In-Reply-To: <1438954951-13329-7-git-send-email-sjg@chromium.org>
On 08/07/2015 07:42 AM, Simon Glass wrote:
> Enable device tree control so that we can use driver model fully and avoid
> using platform data.
I'm still not convinced about this change.
Re: the commit message about: What about the driver model is not being
fully used without DT?
Overall: What advantage does using DT have to either a developer or an
end-user?
I don't believe this patch fixes and bugs or enables any new features
for an end-user.
From the maintainer perspective: It seems to me that it's far simpler to
have a tiny struct for each device in the C code than to pull in a whole
slew of DT parsing cruft just to work out the same struct at run-time.
As such, this patch can only make it harder to maintain the code since
there's more of it, and it's more complex.
I just don't see the advantage of switching to DT for U-Boot control.
next prev parent reply other threads:[~2015-08-11 3:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 13:42 [U-Boot] [PATCH v3 00/11] arm: rpi: Enable USB and Ethernet driver model Raspberry Pi Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 01/11] dm: serial: Update binding for PL01x serial UART Simon Glass
2015-08-11 3:57 ` Stephen Warren
2015-08-11 4:11 ` Simon Glass
2015-08-11 4:24 ` Stephen Warren
2015-08-11 13:00 ` Linus Walleij
2015-08-13 15:59 ` Simon Glass
2015-08-13 16:02 ` Stephen Warren
2015-08-13 18:13 ` Tom Rini
2015-08-13 19:04 ` Ian Lepore
2015-08-13 19:37 ` Stephen Warren
2015-08-14 7:43 ` Geert Uytterhoeven
2015-08-14 10:22 ` Linus Walleij
2015-08-14 14:27 ` Rob Herring
2015-08-14 17:45 ` Ian Lepore
2015-08-14 18:42 ` Stephen Warren
2015-08-17 7:46 ` Linus Walleij
2015-08-14 19:32 ` Pantelis Antoniou
2015-08-13 22:24 ` Rob Herring
2015-08-07 13:42 ` [U-Boot] [PATCH v3 02/11] arm: rpi: Define CONFIG_TFTP_TSIZE to show tftp size info Simon Glass
2015-08-11 3:58 ` Stephen Warren
2016-05-23 15:39 ` Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 03/11] arm: rpi: Bring in kernel device tree files Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 04/11] arm: rpi: Device tree modifications for U-Boot Simon Glass
2015-08-11 4:00 ` Stephen Warren
2015-08-11 4:17 ` Simon Glass
2015-08-11 4:25 ` Stephen Warren
2015-08-12 13:28 ` Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 05/11] arm: rpi: Add device tree files for Raspberry Pi 2 Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 06/11] arm: rpi: Enable device tree control for Rasberry Pi Simon Glass
2015-08-11 3:47 ` Stephen Warren [this message]
2015-08-14 19:20 ` Simon Glass
2015-08-15 3:32 ` Stephen Warren
2015-08-15 13:59 ` Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 07/11] arm: rpi: Enable device tree control for Rasberry Pi 2 Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 08/11] arm: rpi: Drop the UART console platform data Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 09/11] arm: rpi: Drop the GPIO " Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 10/11] arm: rpi: Move to driver model for USB Simon Glass
2015-08-07 13:42 ` [U-Boot] [PATCH v3 11/11] arm: rpi: Use driver model for Ethernet Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C9703D.9040200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox