public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable
Date: Tue, 11 Aug 2015 09:31:55 +0200	[thread overview]
Message-ID: <55C9A4EB.2050704@samsung.com> (raw)
In-Reply-To: <1436391798-28492-1-git-send-email-l.majewski@majess.pl>

Hello Lukasz,

On 07/08/2015 11:43 PM, Lukasz Majewski wrote:
> After extension of the dfu_get_buf() to also setup (implicitly) the dfu_buf_size
> variable it is not needed to set dfu_buf_size to CONFIG_SYS_DFU_DATA_BUF_SIZE.
>
> This variable is set in the dfu_get_buf() by not only considering
> CONFIG_SYS_DFU_DATA_BUF but more importantly the "dfu_bufsiz" env variable.
> Therefore, dfu_get_buf() should be used for initialization.
>
> Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> ---
>   drivers/dfu/dfu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> index 0560afa..332be67 100644
> --- a/drivers/dfu/dfu.c
> +++ b/drivers/dfu/dfu.c
> @@ -76,7 +76,7 @@ int dfu_init_env_entities(char *interface, char *devstr)
>   }
>
>   static unsigned char *dfu_buf;
> -static unsigned long dfu_buf_size = CONFIG_SYS_DFU_DATA_BUF_SIZE;
> +static unsigned long dfu_buf_size;
>
>   unsigned char *dfu_free_buf(void)
>   {
>

Reviewed-by: Przemyslaw Marczak <p.marczak@samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

      reply	other threads:[~2015-08-11  7:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 21:43 [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable Lukasz Majewski
2015-08-11  7:31 ` Przemyslaw Marczak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C9A4EB.2050704@samsung.com \
    --to=p.marczak@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox