[U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable

[U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable

[Lukasz Majewski]

After extension of the dfu_get_buf() to also setup (implicitly) the dfu_buf_size
variable it is not needed to set dfu_buf_size to CONFIG_SYS_DFU_DATA_BUF_SIZE.

This variable is set in the dfu_get_buf() by not only considering
CONFIG_SYS_DFU_DATA_BUF but more importantly the "dfu_bufsiz" env variable.
Therefore, dfu_get_buf() should be used for initialization.

Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
---
 drivers/dfu/dfu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index 0560afa..332be67 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -76,7 +76,7 @@ int dfu_init_env_entities(char *interface, char *devstr)
 }
 
 static unsigned char *dfu_buf;
-static unsigned long dfu_buf_size = CONFIG_SYS_DFU_DATA_BUF_SIZE;
+static unsigned long dfu_buf_size;
 
 unsigned char *dfu_free_buf(void)
 {
-- 
2.1.4

[U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable

[Przemyslaw Marczak]

Hello Lukasz,

On 07/08/2015 11:43 PM, Lukasz Majewski wrote:
> After extension of the dfu_get_buf() to also setup (implicitly) the dfu_buf_size
> variable it is not needed to set dfu_buf_size to CONFIG_SYS_DFU_DATA_BUF_SIZE.
>
> This variable is set in the dfu_get_buf() by not only considering
> CONFIG_SYS_DFU_DATA_BUF but more importantly the "dfu_bufsiz" env variable.
> Therefore, dfu_get_buf() should be used for initialization.
>
> Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> ---
>   drivers/dfu/dfu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> index 0560afa..332be67 100644
> --- a/drivers/dfu/dfu.c
> +++ b/drivers/dfu/dfu.c
> @@ -76,7 +76,7 @@ int dfu_init_env_entities(char *interface, char *devstr)
>   }
>
>   static unsigned char *dfu_buf;
> -static unsigned long dfu_buf_size = CONFIG_SYS_DFU_DATA_BUF_SIZE;
> +static unsigned long dfu_buf_size;
>
>   unsigned char *dfu_free_buf(void)
>   {
>

Reviewed-by: Przemyslaw Marczak <p.marczak@samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com