From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 11 Aug 2015 09:31:55 +0200 Subject: [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable In-Reply-To: <1436391798-28492-1-git-send-email-l.majewski@majess.pl> References: <1436391798-28492-1-git-send-email-l.majewski@majess.pl> Message-ID: <55C9A4EB.2050704@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Lukasz, On 07/08/2015 11:43 PM, Lukasz Majewski wrote: > After extension of the dfu_get_buf() to also setup (implicitly) the dfu_buf_size > variable it is not needed to set dfu_buf_size to CONFIG_SYS_DFU_DATA_BUF_SIZE. > > This variable is set in the dfu_get_buf() by not only considering > CONFIG_SYS_DFU_DATA_BUF but more importantly the "dfu_bufsiz" env variable. > Therefore, dfu_get_buf() should be used for initialization. > > Signed-off-by: Lukasz Majewski > --- > drivers/dfu/dfu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c > index 0560afa..332be67 100644 > --- a/drivers/dfu/dfu.c > +++ b/drivers/dfu/dfu.c > @@ -76,7 +76,7 @@ int dfu_init_env_entities(char *interface, char *devstr) > } > > static unsigned char *dfu_buf; > -static unsigned long dfu_buf_size = CONFIG_SYS_DFU_DATA_BUF_SIZE; > +static unsigned long dfu_buf_size; > > unsigned char *dfu_free_buf(void) > { > Reviewed-by: Przemyslaw Marczak Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com