* [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable
@ 2015-07-08 21:43 Lukasz Majewski
2015-08-11 7:31 ` Przemyslaw Marczak
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Majewski @ 2015-07-08 21:43 UTC (permalink / raw)
To: u-boot
After extension of the dfu_get_buf() to also setup (implicitly) the dfu_buf_size
variable it is not needed to set dfu_buf_size to CONFIG_SYS_DFU_DATA_BUF_SIZE.
This variable is set in the dfu_get_buf() by not only considering
CONFIG_SYS_DFU_DATA_BUF but more importantly the "dfu_bufsiz" env variable.
Therefore, dfu_get_buf() should be used for initialization.
Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
---
drivers/dfu/dfu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index 0560afa..332be67 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -76,7 +76,7 @@ int dfu_init_env_entities(char *interface, char *devstr)
}
static unsigned char *dfu_buf;
-static unsigned long dfu_buf_size = CONFIG_SYS_DFU_DATA_BUF_SIZE;
+static unsigned long dfu_buf_size;
unsigned char *dfu_free_buf(void)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable
2015-07-08 21:43 [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable Lukasz Majewski
@ 2015-08-11 7:31 ` Przemyslaw Marczak
0 siblings, 0 replies; 2+ messages in thread
From: Przemyslaw Marczak @ 2015-08-11 7:31 UTC (permalink / raw)
To: u-boot
Hello Lukasz,
On 07/08/2015 11:43 PM, Lukasz Majewski wrote:
> After extension of the dfu_get_buf() to also setup (implicitly) the dfu_buf_size
> variable it is not needed to set dfu_buf_size to CONFIG_SYS_DFU_DATA_BUF_SIZE.
>
> This variable is set in the dfu_get_buf() by not only considering
> CONFIG_SYS_DFU_DATA_BUF but more importantly the "dfu_bufsiz" env variable.
> Therefore, dfu_get_buf() should be used for initialization.
>
> Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> ---
> drivers/dfu/dfu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> index 0560afa..332be67 100644
> --- a/drivers/dfu/dfu.c
> +++ b/drivers/dfu/dfu.c
> @@ -76,7 +76,7 @@ int dfu_init_env_entities(char *interface, char *devstr)
> }
>
> static unsigned char *dfu_buf;
> -static unsigned long dfu_buf_size = CONFIG_SYS_DFU_DATA_BUF_SIZE;
> +static unsigned long dfu_buf_size;
>
> unsigned char *dfu_free_buf(void)
> {
>
Reviewed-by: Przemyslaw Marczak <p.marczak@samsung.com>
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-11 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-08 21:43 [U-Boot] [PATCH] dfu: Delete superfluous initialization of the dfu_buf_size static variable Lukasz Majewski
2015-08-11 7:31 ` Przemyslaw Marczak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox