From mboxrd@z Thu Jan 1 00:00:00 1970
From: Przemyslaw Marczak
Date: Wed, 12 Aug 2015 12:09:47 +0200
Subject: [U-Boot] [PATCH V3 1/6] power: pfuze100 correct SWBST macro
definition
In-Reply-To: <1438937026-8731-2-git-send-email-Peng.Fan@freescale.com>
References: <1438937026-8731-1-git-send-email-Peng.Fan@freescale.com>
<1438937026-8731-2-git-send-email-Peng.Fan@freescale.com>
Message-ID: <55CB1B6B.40500@samsung.com>
List-Id:
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de
Hello,
On 08/07/2015 10:43 AM, Peng Fan wrote:
> According to datasheet, SWBST_MODE starts from bit 2 and it occupies 2 bits.
> So SWBST_MODE_MASK should be 0xC, and SWBST_MODE_xx should be ([mode] << 2).
>
> Signed-off-by: Peng Fan
> Cc: Przemyslaw Marczak
> Cc: Stefano Babic
> Reviewed-by: Simon Glass
> ---
>
> Changes v3:
> None
>
> Changes v2:
> None
>
> include/power/pfuze100_pmic.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/power/pfuze100_pmic.h b/include/power/pfuze100_pmic.h
> index 57b9ca9..cb10605 100644
> --- a/include/power/pfuze100_pmic.h
> +++ b/include/power/pfuze100_pmic.h
> @@ -193,11 +193,11 @@ enum {
> #define SWBST_5_15V 3
>
> #define SWBST_VOL_MASK 0x3
> -#define SWBST_MODE_MASK 0x6
> -#define SWBST_MODE_OFF (2 << 0)
> -#define SWBST_MODE_PFM (2 << 1)
> +#define SWBST_MODE_MASK 0xC
> +#define SWBST_MODE_OFF (0 << 2)
> +#define SWBST_MODE_PFM (1 << 2)
> #define SWBST_MODE_AUTO (2 << 2)
> -#define SWBST_MODE_APS (2 << 3)
> +#define SWBST_MODE_APS (3 << 2)
>
> /*
> * Regulator Mode Control
>
Applied to: u-boot-pmic.
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com