public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] power: regulator: max77686 correct variable type
Date: Wed, 12 Aug 2015 12:10:17 +0200	[thread overview]
Message-ID: <55CB1B89.2090002@samsung.com> (raw)
In-Reply-To: <1438094828-18069-1-git-send-email-Peng.Fan@freescale.com>

Hello,

On 07/28/2015 04:47 PM, Peng Fan wrote:
> The return type of pmic_read and pmic_write is signed int, so
> correct variable 'ret' from type unsigned int to int.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> ---
>   drivers/power/regulator/max77686.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c
> index 37ebe94..29d2632 100644
> --- a/drivers/power/regulator/max77686.c
> +++ b/drivers/power/regulator/max77686.c
> @@ -313,9 +313,9 @@ static int max77686_ldo_modes(int ldo, struct dm_regulator_mode **modesp,
>
>   static int max77686_ldo_val(struct udevice *dev, int op, int *uV)
>   {
> -	unsigned int ret, hex, adr;
> +	unsigned int hex, adr;
>   	unsigned char val;
> -	int ldo;
> +	int ldo, ret;
>
>   	if (op == PMIC_OP_GET)
>   		*uV = 0;
> @@ -354,9 +354,9 @@ static int max77686_ldo_val(struct udevice *dev, int op, int *uV)
>
>   static int max77686_buck_val(struct udevice *dev, int op, int *uV)
>   {
> -	unsigned int hex, ret, mask, adr;
> +	unsigned int hex, mask, adr;
>   	unsigned char val;
> -	int buck;
> +	int buck, ret;
>
>   	buck = dev->driver_data;
>   	if (buck < 1 || buck > MAX77686_BUCK_NUM) {
> @@ -408,9 +408,9 @@ static int max77686_buck_val(struct udevice *dev, int op, int *uV)
>
>   static int max77686_ldo_mode(struct udevice *dev, int op, int *opmode)
>   {
> -	unsigned int ret, adr, mode;
> +	unsigned int adr, mode;
>   	unsigned char val;
> -	int ldo;
> +	int ldo, ret;
>
>   	if (op == PMIC_OP_GET)
>   		*opmode = -EINVAL;
> @@ -539,9 +539,9 @@ static int max77686_ldo_enable(struct udevice *dev, int op, bool *enable)
>
>   static int max77686_buck_mode(struct udevice *dev, int op, int *opmode)
>   {
> -	unsigned int ret, mask, adr, mode, mode_shift;
> +	unsigned int mask, adr, mode, mode_shift;
>   	unsigned char val;
> -	int buck;
> +	int buck, ret;
>
>   	buck = dev->driver_data;
>   	if (buck < 1 || buck > MAX77686_BUCK_NUM) {
>

Applied to: u-boot-pmic.

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

      parent reply	other threads:[~2015-08-12 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 14:47 [U-Boot] [PATCH] power: regulator: max77686 correct variable type Peng Fan
2015-08-02 22:31 ` Simon Glass
2015-08-12 10:10 ` Przemyslaw Marczak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CB1B89.2090002@samsung.com \
    --to=p.marczak@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox