[U-Boot] [PATCH] power: regulator: max77686 correct variable type

[U-Boot] [PATCH] power: regulator: max77686 correct variable type

[Peng Fan]

The return type of pmic_read and pmic_write is signed int, so
correct variable 'ret' from type unsigned int to int.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Przemyslaw Marczak <p.marczak@samsung.com>
---
 drivers/power/regulator/max77686.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c
index 37ebe94..29d2632 100644
--- a/drivers/power/regulator/max77686.c
+++ b/drivers/power/regulator/max77686.c
@@ -313,9 +313,9 @@ static int max77686_ldo_modes(int ldo, struct dm_regulator_mode **modesp,
 
 static int max77686_ldo_val(struct udevice *dev, int op, int *uV)
 {
-	unsigned int ret, hex, adr;
+	unsigned int hex, adr;
 	unsigned char val;
-	int ldo;
+	int ldo, ret;
 
 	if (op == PMIC_OP_GET)
 		*uV = 0;
@@ -354,9 +354,9 @@ static int max77686_ldo_val(struct udevice *dev, int op, int *uV)
 
 static int max77686_buck_val(struct udevice *dev, int op, int *uV)
 {
-	unsigned int hex, ret, mask, adr;
+	unsigned int hex, mask, adr;
 	unsigned char val;
-	int buck;
+	int buck, ret;
 
 	buck = dev->driver_data;
 	if (buck < 1 || buck > MAX77686_BUCK_NUM) {
@@ -408,9 +408,9 @@ static int max77686_buck_val(struct udevice *dev, int op, int *uV)
 
 static int max77686_ldo_mode(struct udevice *dev, int op, int *opmode)
 {
-	unsigned int ret, adr, mode;
+	unsigned int adr, mode;
 	unsigned char val;
-	int ldo;
+	int ldo, ret;
 
 	if (op == PMIC_OP_GET)
 		*opmode = -EINVAL;
@@ -539,9 +539,9 @@ static int max77686_ldo_enable(struct udevice *dev, int op, bool *enable)
 
 static int max77686_buck_mode(struct udevice *dev, int op, int *opmode)
 {
-	unsigned int ret, mask, adr, mode, mode_shift;
+	unsigned int mask, adr, mode, mode_shift;
 	unsigned char val;
-	int buck;
+	int buck, ret;
 
 	buck = dev->driver_data;
 	if (buck < 1 || buck > MAX77686_BUCK_NUM) {
-- 
1.8.4

[U-Boot] [PATCH] power: regulator: max77686 correct variable type

[Simon Glass]

On 28 July 2015 at 08:47, Peng Fan <Peng.Fan@freescale.com> wrote:
> The return type of pmic_read and pmic_write is signed int, so
> correct variable 'ret' from type unsigned int to int.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> ---
>  drivers/power/regulator/max77686.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>

Acked-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] power: regulator: max77686 correct variable type

[Przemyslaw Marczak]

Hello,

On 07/28/2015 04:47 PM, Peng Fan wrote:
> The return type of pmic_read and pmic_write is signed int, so
> correct variable 'ret' from type unsigned int to int.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> ---
>   drivers/power/regulator/max77686.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c
> index 37ebe94..29d2632 100644
> --- a/drivers/power/regulator/max77686.c
> +++ b/drivers/power/regulator/max77686.c
> @@ -313,9 +313,9 @@ static int max77686_ldo_modes(int ldo, struct dm_regulator_mode **modesp,
>
>   static int max77686_ldo_val(struct udevice *dev, int op, int *uV)
>   {
> -	unsigned int ret, hex, adr;
> +	unsigned int hex, adr;
>   	unsigned char val;
> -	int ldo;
> +	int ldo, ret;
>
>   	if (op == PMIC_OP_GET)
>   		*uV = 0;
> @@ -354,9 +354,9 @@ static int max77686_ldo_val(struct udevice *dev, int op, int *uV)
>
>   static int max77686_buck_val(struct udevice *dev, int op, int *uV)
>   {
> -	unsigned int hex, ret, mask, adr;
> +	unsigned int hex, mask, adr;
>   	unsigned char val;
> -	int buck;
> +	int buck, ret;
>
>   	buck = dev->driver_data;
>   	if (buck < 1 || buck > MAX77686_BUCK_NUM) {
> @@ -408,9 +408,9 @@ static int max77686_buck_val(struct udevice *dev, int op, int *uV)
>
>   static int max77686_ldo_mode(struct udevice *dev, int op, int *opmode)
>   {
> -	unsigned int ret, adr, mode;
> +	unsigned int adr, mode;
>   	unsigned char val;
> -	int ldo;
> +	int ldo, ret;
>
>   	if (op == PMIC_OP_GET)
>   		*opmode = -EINVAL;
> @@ -539,9 +539,9 @@ static int max77686_ldo_enable(struct udevice *dev, int op, bool *enable)
>
>   static int max77686_buck_mode(struct udevice *dev, int op, int *opmode)
>   {
> -	unsigned int ret, mask, adr, mode, mode_shift;
> +	unsigned int mask, adr, mode, mode_shift;
>   	unsigned char val;
> -	int buck;
> +	int buck, ret;
>
>   	buck = dev->driver_data;
>   	if (buck < 1 || buck > MAX77686_BUCK_NUM) {
>

Applied to: u-boot-pmic.

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com