public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 00/10] Replace the FAT filesystem code
Date: Fri, 14 Aug 2015 21:36:45 -0600	[thread overview]
Message-ID: <55CEB3CD.5030807@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ0rQCPe_jgkfJsy9kx0jZY73xnNQYC=efUmUCs9RWFkZw@mail.gmail.com>

On 08/12/2015 08:56 PM, Simon Glass wrote:
> Hi Stephen,
> 
> On 11 August 2015 at 08:55, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> The existing FAT filesystem implementation in U-Boot has some bugs that
>> are tricky to fix cleanly without significant rework of the code. For
>> example, see:
>>
>> http://lists.denx.de/pipermail/u-boot/2015-July/221054.html
>> [PATCH] fat: handle paths that include ../
>>
>> This series replaces U-Boot's FAT filesystem implementation with the "ff"
>> project; http://elm-chan.org/fsw/ff/00index_e.html. This project appears
>> to be actively maintained, does not have at least the bug referenced in
>> the patch link above, and is quite easy to integrate into U-Boot. An
>> earlier version is also used in Barebox, so presumably it's had some
>> level of testing/exposure there.
>>
> 
> This seems like a good idea to me. Are there some standard tests for
> FAT that we can bring in also? Perhaps using sandbox? At present we
> have fs-test.sh which is a start.

This series does pass fs-test.sh, which caught a couple of bugs. It
would be nice to ensure that the image fs-test.sh creates cause all of
FAT12/16/32 to be parsed. It'd also be nice to extend it with a check
for the bug that triggered me to start fiddling with FAT; /foo/../xxx
where xxx is past the first sector (cluster?) of the root directory. We
could likely test for volume ID retrieval, ls output, ... too. Many
options to extend the test; all will take time though.

  reply	other threads:[~2015-08-15  3:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 14:55 [U-Boot] [PATCH V2 00/10] Replace the FAT filesystem code Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 01/10] disk: support host devices in dev_print() Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 02/10] fat: move to a different directory Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 03/10] fat: add ff.c implementation Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 04/10] fat: apply upstream bugfix to ff.c Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 05/10] fat: ff: add ifdef to avoid unused function warning Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 06/10] fat: ffconf.h changes for U-Boot port Stephen Warren
2015-08-14 18:47   ` Tom Rini
2015-08-15  3:40     ` Stephen Warren
2015-08-15 13:07       ` Tom Rini
2015-08-19  4:01         ` Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 07/10] fat: port integer.h to U-Boot types Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 08/10] fat: add U-Boot to ff.c API conversion wrapper Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 09/10] fat: switch to new FAT implementation Stephen Warren
2015-08-11 14:55 ` [U-Boot] [PATCH V2 10/10] fat: remove old implementation Stephen Warren
2015-08-13  2:56 ` [U-Boot] [PATCH V2 00/10] Replace the FAT filesystem code Simon Glass
2015-08-15  3:36   ` Stephen Warren [this message]
2015-08-14 19:29 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CEB3CD.5030807@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox