public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] arm: at91: at91sam9m10g45ek/corvus remove useless chip select 1 init
Date: Tue, 18 Aug 2015 12:30:26 +0200	[thread overview]
Message-ID: <55D30942.3090307@gmail.com> (raw)
In-Reply-To: <1439473401-4544-3-git-send-email-evanluijk@interact.nl>

Hi Erik,

On 08/13/2015 03:43 PM, Erik van Luijk wrote:
> On these boards the DDR is connected to a dedicated controller and not
> to chip select 1 of the EBI.

from the specs this seems correct. Could I please get a Tested-by, since
I do not own one of these boards.

Best regards

Andreas

> 
> Signed-off-by: Erik van Luijk <evanluijk@interact.nl>
> ---
>  board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 8 --------
>  board/siemens/corvus/board.c                    | 8 --------
>  2 files changed, 16 deletions(-)
> 
> diff --git a/board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c b/board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c
> index 3e65d71..d2ade4d 100644
> --- a/board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c
> +++ b/board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c
> @@ -131,21 +131,13 @@ static void ddr2_conf(struct atmel_mpddr *ddr2)
>  void mem_init(void)
>  {
>  	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> -	struct at91_matrix *mat = (struct at91_matrix *)ATMEL_BASE_MATRIX;
>  	struct atmel_mpddr ddr2;
> -	unsigned long csa;
>  
>  	ddr2_conf(&ddr2);
>  
>  	/* enable DDR2 clock */
>  	writel(0x4, &pmc->scer);
>  
> -	/* Chip select 1 is for DDR2/SDRAM */
> -	csa = readl(&mat->ebicsa);
> -	csa |= AT91_MATRIX_EBI_CS1A_SDRAMC;
> -	csa &= ~AT91_MATRIX_EBI_VDDIOMSEL_3_3V;
> -	writel(csa, &mat->ebicsa);
> -
>  	/* DDRAM2 Controller initialize */
>  	ddr2_init(ATMEL_BASE_DDRSDRC0, ATMEL_BASE_CS6, &ddr2);
>  }
> diff --git a/board/siemens/corvus/board.c b/board/siemens/corvus/board.c
> index 9001fcbcf..d74743f 100644
> --- a/board/siemens/corvus/board.c
> +++ b/board/siemens/corvus/board.c
> @@ -144,21 +144,13 @@ static void ddr2_conf(struct atmel_mpddr *ddr2)
>  void mem_init(void)
>  {
>  	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> -	struct at91_matrix *mat = (struct at91_matrix *)ATMEL_BASE_MATRIX;
>  	struct atmel_mpddr ddr2;
> -	unsigned long csa;
>  
>  	ddr2_conf(&ddr2);
>  
>  	/* enable DDR2 clock */
>  	writel(0x4, &pmc->scer);
>  
> -	/* Chip select 1 is for DDR2/SDRAM */
> -	csa = readl(&mat->ebicsa);
> -	csa |= AT91_MATRIX_EBI_CS1A_SDRAMC;
> -	csa &= ~AT91_MATRIX_EBI_VDDIOMSEL_3_3V;
> -	writel(csa, &mat->ebicsa);
> -
>  	/* DDRAM2 Controller initialize */
>  	ddr2_init(ATMEL_BASE_DDRSDRC0, ATMEL_BASE_CS6, &ddr2);
>  }
> 

  reply	other threads:[~2015-08-18 10:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 13:43 [U-Boot] [PATCH 0/4] arm: at91: change mpddr and support picosam9g45 Erik van Luijk
2015-08-13 13:43 ` [U-Boot] [PATCH 1/4] arm: at91: mpddr: allow multiple DDR controllers Erik van Luijk
2015-08-21 13:27   ` [U-Boot] [U-Boot, " Andreas Bießmann
2015-08-13 13:43 ` [U-Boot] [PATCH 2/4] arm: at91: at91sam9m10g45ek/corvus remove useless chip select 1 init Erik van Luijk
2015-08-18 10:30   ` Andreas Bießmann [this message]
2015-08-18 12:43     ` Erik van Luijk
2015-08-21 13:27   ` [U-Boot] [U-Boot, " Andreas Bießmann
2015-08-13 13:43 ` [U-Boot] [PATCH 3/4] arm: at91: pmc: replace the constant with a define in at91_pmc.h Erik van Luijk
2015-08-18 10:34   ` Andreas Bießmann
2015-08-21 13:27   ` [U-Boot] [U-Boot, " Andreas Bießmann
2015-08-13 13:43 ` [U-Boot] [PATCH 4/4] arm: at91: add support for mini-box picosam9g45 board Erik van Luijk
2015-08-17 10:47   ` [U-Boot] [PATCH v2 " Erik van Luijk
2015-08-21 13:28     ` [U-Boot] [U-Boot, v2, " Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D30942.3090307@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox