From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Thu, 20 Aug 2015 08:33:01 +0200 Subject: [U-Boot] [PATCH 01/15] sunxi_nand_spl: Fix CONFIG_SPL_NAND_SUNXI handling In-Reply-To: <20150819134500.GE30520@lukather> References: <1439668968-3882-1-git-send-email-hdegoede@redhat.com> <1439668968-3882-2-git-send-email-hdegoede@redhat.com> <20150819134500.GE30520@lukather> Message-ID: <55D5749D.2010600@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 08/19/2015 03:45 PM, Maxime Ripard wrote: > On Sat, Aug 15, 2015 at 10:02:34PM +0200, Hans de Goede wrote: >> CONFIG_SPL_NAND_SUPPORT gets used via IS_ENABLED so it must be defined >> to 1, rather then just being defined. >> >> While at remove 2 other unused NAND related defines from sunxi-common.h. >> >> Signed-off-by: Hans de Goede >> --- >> include/configs/sunxi-common.h | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h >> index 1abf73c..3735afb 100644 >> --- a/include/configs/sunxi-common.h >> +++ b/include/configs/sunxi-common.h >> @@ -138,15 +138,10 @@ >> #define CONFIG_SERIAL_TAG >> >> #if defined(CONFIG_SPL_NAND_SUNXI) >> -#define CONFIG_SPL_NAND_DRIVERS >> -#define CONFIG_SPL_NAND_SUPPORT >> - >> -#define CONFIG_SYS_NAND_SPL_KERNEL_OFFS 0x280000 >> +#define CONFIG_SPL_NAND_SUPPORT 1 > > Every other platform just use an empty define for this one, and the > only user of IS_ENABLED together with this option is the sunxi > board. Why not simply replace the IS_ENABLED by an ifdef to maintain > consistency? Because u-boot is moving to Kconfig which will define it to 1, and ... > AFAIK, IS_ENABLED doesn't bring anythnig to the table here. IS_ENABLED leads too cleaner / easier to read code, so it does bring something to the table. REgards, Hans