public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] sysboot: Add support for ubifs to the sysboot command
Date: Thu, 20 Aug 2015 13:53:47 -0600	[thread overview]
Message-ID: <55D6304B.3090900@wwwdotorg.org> (raw)
In-Reply-To: <1440086655-1246-1-git-send-email-hdegoede@redhat.com>

On 08/20/2015 10:04 AM, Hans de Goede wrote:
> ubifs does not go though the generic block layer because mtd devices
> are special, so the "any" filesystem option to sysboot does not work,
> this adds support for a "ubifs" filesystem to the sysboot command which
> makes it possible to boot from ubifs using an extlinux.conf file.

Why are they special? Surely ubifs support can be integrated into the 
filesystem layer, thus removing the need for patches 1 and 3 in this series?

The problem here is that in patch 3,BOOTENV_DEV_UBIFS and 
BOOTENV_SHARED_UBIFS duplicate the file looping logic that already exist 
in other block device scanning macros. Naively it looks like it should 
be possible to avoid that completely. One change I vaguely had in mind 
for the distro boot scripts was to add a user-configurable environment 
variable to specify which of extlinux, script (and later perhaps 
Android, ...) support each partition was scanned for. Any time a change 
like that is made, with this patch applied first, that change would have 
to be replicated twice (and potentially n times if we continue down this 
path).

  parent reply	other threads:[~2015-08-20 19:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 16:04 [U-Boot] [PATCH 1/3] sysboot: Add support for ubifs to the sysboot command Hans de Goede
2015-08-20 16:04 ` [U-Boot] [PATCH 2/3] ubifs: Add a ubifsexists command Hans de Goede
2015-08-20 16:04 ` [U-Boot] [PATCH 3/3] distro_bootcmd: Add support for booting from ubifs Hans de Goede
2015-08-20 19:53 ` Stephen Warren [this message]
2015-08-21  9:56 ` [U-Boot] [U-Boot, 1/3] sysboot: Add support for ubifs to the sysboot command Hans de Goede
2015-08-21 22:01   ` Stephen Warren
2015-08-22 18:04     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D6304B.3090900@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox