public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] arm: tegra20: implement early pmic rail configuration
Date: Thu, 20 Aug 2015 14:01:00 -0600	[thread overview]
Message-ID: <55D631FC.5010205@wwwdotorg.org> (raw)
In-Reply-To: <1440057163-20081-2-git-send-email-marcel.ziswiler@toradex.com>

On 08/20/2015 01:52 AM, Marcel Ziswiler wrote:
> Implement early TPS6586X PMIC rail configuration setting SM0 being
> VDD_CORE_1.2V to 1.2 volts and SM1 being VDD_CPU_1.0V to 1.0 volts.
>
> While those are PMIC power-up defaults the SoC might have been reset
> separately with certain rails being left at lower DVFS states which
> is e.g. the case upon watchdog reset while otherwise nearly idling.

> diff --git a/arch/arm/mach-tegra/tegra20/cpu.c b/arch/arm/mach-tegra/tegra20/cpu.c

>   static void enable_cpu_power_rail(void)
>   {
>   	struct pmc_ctlr *pmc = (struct pmc_ctlr *)NV_PA_PMC_BASE;
>   	u32 reg;
>
> +	debug("%s entry\n", __func__);
> +
> +#ifdef CONFIG_TEGRA_EARLY_TPS6586X
> +	tegra_i2c_ll_init();
> +
> +	/* Set SM0 being VDD_CORE_1.2V to 1.2 volts */
> +	tegra_i2c_ll_write(TPS6586X_SM0V1_REG, 0x13);

Does the CORE rail get adjusted by DVFS? Hopefully if it does, it is 
never set so low that AVP operation at reset is impossible...

> +	udelay(1000);

all the delays in this patch seem very large. What drove the choice of 
the delay values?

  reply	other threads:[~2015-08-20 20:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20  7:52 [U-Boot] [PATCH 0/3] arm: tegra20/colibri_t20: early pmic rail configuration Marcel Ziswiler
2015-08-20  7:52 ` [U-Boot] [PATCH 1/3] arm: tegra20: implement " Marcel Ziswiler
2015-08-20 20:01   ` Stephen Warren [this message]
2015-08-20  7:52 ` [U-Boot] [PATCH 2/3] colibri_t20: enable " Marcel Ziswiler
2015-08-20 20:02   ` Stephen Warren
2015-08-20  7:52 ` [U-Boot] [PATCH 3/3] colibri_t20: get rid of spurious MAX_I2C_RETRY define Marcel Ziswiler
2015-08-20 19:59 ` [U-Boot] [PATCH 0/3] arm: tegra20/colibri_t20: early pmic rail configuration Stephen Warren
  -- strict thread matches above, loose matches on Subject: below --
2015-08-20 23:06 [U-Boot] [PATCH 1/3] arm: tegra20: implement " Marcel Ziswiler
2015-08-24 16:28 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D631FC.5010205@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox