public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] include: configs: Enable DWC3 and DFU in ti_omap5_common
Date: Fri, 21 Aug 2015 11:27:33 +0530	[thread overview]
Message-ID: <55D6BDCD.7050701@ti.com> (raw)
In-Reply-To: <20150820175621.GW25532@bill-the-cat>

Hi Tom,

On Thursday 20 August 2015 11:26 PM, Tom Rini wrote:
> On Wed, Aug 19, 2015 at 02:13:21PM +0530, Kishon Vijay Abraham I wrote:
> 
>> Enabled configs for dwc3, dwc3-omap and PHY for dwc3 in
>> ti_omap5_common. Also enabled support for DFU.
>>
>> Since ti_omap5_common is used by dra7 too, removed these configs
>> from dra7xx_evm config file.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> This is starting to move board-specific stuff (like using DFU) into the
> common file for all OMAP5 boards, so I don't like this.  NAK in concept,
> thanks!

Since we have added support for DFU for all the OMAP5 based boards
(including DRA's), thought it is better to add in a common file which is
used by all these boards.

So do you prefer the configs be added in dra7xx_evm.h, omap5_evm.h,
beagle_x15.h etc..

Thanks
Kishon

  reply	other threads:[~2015-08-21  5:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19  8:43 [U-Boot] [PATCH 0/3] ti: add usb peripheral support for omap5 and beagle x15 Kishon Vijay Abraham I
2015-08-19  8:43 ` [U-Boot] [PATCH 1/3] board: ti: beagle_x15: added USB initializtion code Kishon Vijay Abraham I
2015-08-20 17:54   ` Tom Rini
2015-08-28 21:04   ` [U-Boot] [U-Boot, " Tom Rini
2015-08-19  8:43 ` [U-Boot] [PATCH 2/3] board: ti: OMAP5: " Kishon Vijay Abraham I
2015-08-20 17:54   ` Tom Rini
2015-08-28 21:04   ` [U-Boot] [U-Boot, " Tom Rini
2015-08-19  8:43 ` [U-Boot] [PATCH 3/3] include: configs: Enable DWC3 and DFU in ti_omap5_common Kishon Vijay Abraham I
2015-08-20 17:56   ` Tom Rini
2015-08-21  5:57     ` Kishon Vijay Abraham I [this message]
2015-08-24 16:11       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D6BDCD.7050701@ti.com \
    --to=kishon@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox