public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm, at91: add axm extensions
Date: Fri, 21 Aug 2015 15:45:04 +0200	[thread overview]
Message-ID: <55D72B60.8010706@gmail.com> (raw)
In-Reply-To: <1439906054-18372-1-git-send-email-hs@denx.de>

Hi Heiko,

On 08/18/2015 03:54 PM, Heiko Schocher wrote:
> add extensions for the axm board:
> - power on LED on power up
> - press both recovery buttons on power up to enter
>   recovery mode
> - detect 64 MiB and 128 MiB ramsize
> - PHY rest at reboot because of ATMEL bug
> - use siemens update concept
> - add axm default environment
> - set CONFIG_SPL_MAX_SIZE to 15k
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> 
> ---
> 
> Changes in v2:
> - add comments from Andreas Biessmann:
>   - set stack into second sram segment
>   - fix some Coding Style issues
>   - reworked "suspect code indent" warning
>   - reworked update concept
>   - rebase against 0d339cf9a969f0c249713d3697e735184f1bd955
> 
>  board/siemens/taurus/taurus.c | 196 ++++++++++++++++++++++++++++++++++++++----
>  include/configs/taurus.h      |  70 ++++++++++++++-
>  2 files changed, 248 insertions(+), 18 deletions(-)


> diff --git a/include/configs/taurus.h b/include/configs/taurus.h
> index 2c9f5da..1a7e561 100644
> --- a/include/configs/taurus.h
> +++ b/include/configs/taurus.h

> @@ -182,8 +245,8 @@
>  /* Defines for SPL */
>  #define CONFIG_SPL_FRAMEWORK
>  #define CONFIG_SPL_TEXT_BASE		0x0
> -#define CONFIG_SPL_MAX_SIZE		(14 * 1024)
> -#define CONFIG_SPL_STACK		(16 * 1024)
> +#define CONFIG_SPL_MAX_SIZE		(31 * SZ_512)
> +#define	CONFIG_SPL_STACK		(ATMEL_BASE_SRAM1 + SZ_16K)

NAK, those two changes generate

---8<---
+arch/arm/lib/crt0.S:180: undefined reference to `SZ_16K'
+u-boot-spl.lds:57: undefined symbol `SZ_512' referenced in expression
--->8---

Sorry for the rash 'accepted' mail ...

Andreas

      parent reply	other threads:[~2015-08-21 13:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 13:54 [U-Boot] [PATCH v2] arm, at91: add axm extensions Heiko Schocher
2015-08-21 13:28 ` [U-Boot] [U-Boot,v2] " Andreas Bießmann
2015-08-21 13:45 ` Andreas Bießmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D72B60.8010706@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox