From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ehci: remember init mode
Date: Fri, 21 Aug 2015 15:58:55 -0600 [thread overview]
Message-ID: <55D79F1F.1090809@wwwdotorg.org> (raw)
In-Reply-To: <201508210734.50164.marex@denx.de>
On 08/20/2015 11:34 PM, Marek Vasut wrote:
> On Friday, August 21, 2015 at 01:38:05 AM, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> When an EHCI device is registered in device mode, the HW isn't actually
>> initialized at all, and hence isn't left in a running state. Consequently,
>> when the device is deregistered, ehci_shutdown() will fail, since the HW
>> bits it expects to see set in response to its shutdown requests will not
>> be sent, and the message "EHCI failed to shut down host controller." will
>> be printed.
>>
>> Fix ehci-hcd.c to remember whether the device was registered in host or
>> device mode, and only call ehci_shutdown() for host mode registrations.
>
> Hi,
>
> Shouldn't you instead check if the controller is running or not and shut
> it down based on that ?
Why would the two states be different? How can the code check if the
controller is running; is there some HW bit that should be checked for that?
next prev parent reply other threads:[~2015-08-21 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 23:38 [U-Boot] [PATCH] usb: ehci: remember init mode Stephen Warren
2015-08-21 5:34 ` Marek Vasut
2015-08-21 21:58 ` Stephen Warren [this message]
2015-08-24 3:47 ` Marek Vasut
2015-08-24 18:57 ` Stephen Warren
2015-08-27 10:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D79F1F.1090809@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox