From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/28] tpm: Remove old pre-driver-model I2C code
Date: Mon, 24 Aug 2015 07:15:17 +0200 [thread overview]
Message-ID: <55DAA865.6040607@denx.de> (raw)
In-Reply-To: <CAPnjgZ1HR-reU_q-Sc_G4gGAqdGKybkvGfwJGsZA+UG34SbZ1g@mail.gmail.com>
Hello Simon,
Am 24.08.2015 um 06:52 schrieb Simon Glass:
> Hi Heiko,
>
> On 23 August 2015 at 22:50, Heiko Schocher <hs@denx.de> wrote:
>> Hello Simon,
>>
>> Am 23.08.2015 um 02:31 schrieb Simon Glass:
>>>
>>> This is not used anymore by any board so drop it.
>>>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>> Acked-by: Christophe Ricard <christophe-h.ricard@st.com>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>> drivers/tpm/tpm.c | 108
>>> ++--------------------------------------------
>>> drivers/tpm/tpm_private.h | 4 +-
>>> drivers/tpm/tpm_tis_i2c.c | 74 +------------------------------
>>> 3 files changed, 7 insertions(+), 179 deletions(-)
>>
>>
>> Thanks for your work! Nitpick ...
>>
>> $ grep -lr CONFIG_TPM_TIS_I2C include/configs/
>> include/configs/exynos5-common.h
>>
>> So I miss the removal of this define there and maybe
>> remove it in drivers/tpm/Makefile ...
>>
>> Beside of this ...
>>
>> Reviewed-by: Heiko Schocher <hs@denx.de>
>
> The driver still exists though - I am just removing part of the code.
> Or do I misunderstand what you are getting at?
Huh... seems to early ... I thought you remove the complete driver,
Sorry ... all is fine.
I looked through your patchserie, seems fine to me, so, you can add
my Reviewed-by: Heiko Schocher <hs@denx.de> for the hole series.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-08-24 5:15 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 0:31 [U-Boot] [PATCH v2 00/28] dm: Convert TPM drivers to driver model Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 01/28] tpm: Remove old pre-driver-model I2C code Simon Glass
2015-08-24 4:50 ` Heiko Schocher
2015-08-24 4:52 ` Simon Glass
2015-08-24 5:15 ` Heiko Schocher [this message]
2015-08-30 22:42 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 02/28] tpm: Drop two unused options Simon Glass
2015-08-30 22:42 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 03/28] tpm: Add Kconfig options for TPMs Simon Glass
2015-08-24 20:24 ` Christophe Ricard
2015-08-30 22:42 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 04/28] tpm: Convert board config TPM options to Kconfig Simon Glass
2015-08-24 20:20 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 05/28] tpm: Convert drivers to use SPDX Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 06/28] tpm: Move the I2C TPM code into one file Simon Glass
2015-08-24 20:24 ` Christophe Ricard
2015-08-25 4:13 ` Simon Glass
2015-08-25 18:38 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 07/28] tpm: tpm_tis_i2c: Drop unnecessary methods Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 08/28] tpm: tpm_tis_i2c: Drop struct tpm_vendor_specific Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 09/28] tpm: tpm_tis_i2c: Merge struct tpm_dev into tpm_chip Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 10/28] tpm: tpm_tis_i2c: Merge struct tpm " Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 11/28] tpm: tpm_tis_i2c: Move definitions into the header file Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 12/28] tpm: tpm_tis_i2c: Simplify init code Simon Glass
2015-08-24 20:20 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 13/28] tpm: tpm_tis_i2c: Use a consistent tpm_tis_i2c_ prefix Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 14/28] tpm: tpm_tis_i2c: Tidy up delays Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 15/28] dm: tpm: Add a uclass for Trusted Platform Modules Simon Glass
2015-08-24 20:21 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 16/28] dm: tpm: Convert the TPM command and library to driver model Simon Glass
2015-08-24 20:21 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 17/28] dm: i2c: Add a command to adjust the offset length Simon Glass
2015-08-24 20:21 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 18/28] tpm: Report tpm errors on the command line Simon Glass
2015-08-24 20:21 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 19/28] dm: tpm: sandbox: Convert TPM driver to driver model Simon Glass
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 20/28] tpm: Check that parse_byte_string() has data to parse Simon Glass
2015-08-24 20:22 ` Christophe Ricard
2015-08-25 4:13 ` Simon Glass
2015-08-25 18:40 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 21/28] exynos: x86: dts: Add tpm nodes to the device tree for Chrome OS devices Simon Glass
2015-08-24 20:22 ` Christophe Ricard
2015-08-30 22:43 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 22/28] dm: tpm: Convert I2C driver to driver model Simon Glass
2015-08-24 20:22 ` Christophe Ricard
2015-08-30 22:44 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 23/28] dm: tpm: Convert LPC " Simon Glass
2015-08-24 20:23 ` Christophe Ricard
2015-08-30 22:44 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 24/28] tpm: Add a 'tpm info' command Simon Glass
2015-08-30 22:44 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 25/28] tpm: Add functions to access flags and permissions Simon Glass
2015-08-24 20:23 ` Christophe Ricard
2015-08-30 22:44 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 26/28] dm: tpm: Add a 'tpmtest' command Simon Glass
2015-08-24 20:23 ` Christophe Ricard
2015-08-30 22:44 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 27/28] tpm: Enable 'tpmtest' command for Chrome OS boards with TPMs Simon Glass
2015-08-24 20:23 ` Christophe Ricard
2015-08-30 22:44 ` Simon Glass
2015-08-23 0:31 ` [U-Boot] [PATCH v2 28/28] tegra: nyan: Enable TPM command and driver Simon Glass
2015-08-30 22:44 ` Simon Glass
2015-08-24 20:20 ` [U-Boot] [PATCH v2 00/28] dm: Convert TPM drivers to driver model Christophe Ricard
2015-08-25 4:13 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DAA865.6040607@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox