From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 24 Aug 2015 07:15:17 +0200 Subject: [U-Boot] [PATCH v2 01/28] tpm: Remove old pre-driver-model I2C code In-Reply-To: References: <1440289904-31280-1-git-send-email-sjg@chromium.org> <1440289904-31280-2-git-send-email-sjg@chromium.org> <55DAA29F.6020305@denx.de> Message-ID: <55DAA865.6040607@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, Am 24.08.2015 um 06:52 schrieb Simon Glass: > Hi Heiko, > > On 23 August 2015 at 22:50, Heiko Schocher wrote: >> Hello Simon, >> >> Am 23.08.2015 um 02:31 schrieb Simon Glass: >>> >>> This is not used anymore by any board so drop it. >>> >>> Signed-off-by: Simon Glass >>> Acked-by: Christophe Ricard >>> --- >>> >>> Changes in v2: None >>> >>> drivers/tpm/tpm.c | 108 >>> ++-------------------------------------------- >>> drivers/tpm/tpm_private.h | 4 +- >>> drivers/tpm/tpm_tis_i2c.c | 74 +------------------------------ >>> 3 files changed, 7 insertions(+), 179 deletions(-) >> >> >> Thanks for your work! Nitpick ... >> >> $ grep -lr CONFIG_TPM_TIS_I2C include/configs/ >> include/configs/exynos5-common.h >> >> So I miss the removal of this define there and maybe >> remove it in drivers/tpm/Makefile ... >> >> Beside of this ... >> >> Reviewed-by: Heiko Schocher > > The driver still exists though - I am just removing part of the code. > Or do I misunderstand what you are getting at? Huh... seems to early ... I thought you remove the complete driver, Sorry ... all is fine. I looked through your patchserie, seems fine to me, so, you can add my Reviewed-by: Heiko Schocher for the hole series. Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany