From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] colibri_t20: enable early pmic rail configuration
Date: Mon, 24 Aug 2015 10:29:10 -0600 [thread overview]
Message-ID: <55DB4656.5010305@wwwdotorg.org> (raw)
In-Reply-To: <088341bc-22cd-4d4a-a428-63697eacbd76@email.android.com>
On 08/20/2015 05:13 PM, Marcel Ziswiler wrote:
> On 20 Aug 2015 22:01, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
> > Rather than enable this with yet another CONFIG_ option, perhaps we can
> > put this code into a C file dedicated to the colibri_t20 board, and then
> > have the common code call it (and implement a weak function that does
> > nothing to satisfy the linker on other boards).
>
> I'm fine with that but during my initial investigation I noticed that
> there are at least 3 to 4 different ways how the early PMIC
> configuration could be realised just within the Tegra's and your
> proposal is not even one of them.
My proposal has nothing to do with how the PMIC code is implemented,
simply where to invoke it. This ensures that board-specific code doesn't
get dumped into core files.
next prev parent reply other threads:[~2015-08-24 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 23:13 [U-Boot] [PATCH 2/3] colibri_t20: enable early pmic rail configuration Marcel Ziswiler
2015-08-24 16:29 ` Stephen Warren [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-20 7:52 [U-Boot] [PATCH 0/3] arm: tegra20/colibri_t20: " Marcel Ziswiler
2015-08-20 7:52 ` [U-Boot] [PATCH 2/3] colibri_t20: enable " Marcel Ziswiler
2015-08-20 20:02 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB4656.5010305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox