From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christophe Ricard <christophe.ricard@gmail.com>
Date: Mon, 24 Aug 2015 22:22:11 +0200
Subject: [U-Boot] [PATCH v2 20/28] tpm: Check that parse_byte_string()
 has data to parse
In-Reply-To: <1440289904-31280-21-git-send-email-sjg@chromium.org>
References: <1440289904-31280-1-git-send-email-sjg@chromium.org>
 <1440289904-31280-21-git-send-email-sjg@chromium.org>
Message-ID: <55DB7CF3.4010906@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

Print an error ? Are you sure ? I guess the comment is not accurate ;).

Best Regards
Christophe

On 23/08/2015 02:31, Simon Glass wrote:
> Rather then crashing when there is no data, print an error.
>
> Acked-by: Christophe Ricard <christophe-h.ricard@st.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2: None
>
>   common/cmd_tpm.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/common/cmd_tpm.c b/common/cmd_tpm.c
> index 65e7371..e9c6618 100644
> --- a/common/cmd_tpm.c
> +++ b/common/cmd_tpm.c
> @@ -58,6 +58,8 @@ static void *parse_byte_string(char *bytes, uint8_t *data, size_t *count_ptr)
>   	size_t count, length;
>   	int i;
>   
> +	if (!bytes)
> +		return NULL;
>   	length = strlen(bytes);
>   	count = length / 2;
>