public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 04/33] mmc: Support bypass mode with the get_mmc_clk() method
Date: Tue, 25 Aug 2015 11:18:28 +0900	[thread overview]
Message-ID: <55DBD074.4010501@samsung.com> (raw)
In-Reply-To: <1440429171-2555-5-git-send-email-sjg@chromium.org>

Hi, Simon.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

On 08/25/2015 12:12 AM, Simon Glass wrote:
> Some SoCs want to adjust the input clock to the DWMMC block as a way of
> controlling the MMC bus clock. Update the get_mmc_clk() method to support
> this.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/mmc/dw_mmc.c        |  2 +-
>  drivers/mmc/exynos_dw_mmc.c |  2 +-
>  include/dwmmc.h             | 16 +++++++++++++++-
>  3 files changed, 17 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 77b87e0..1117fed 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -266,7 +266,7 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq)
>  	 * host->bus_hz should be set by user.
>  	 */
>  	if (host->get_mmc_clk)
> -		sclk = host->get_mmc_clk(host);
> +		sclk = host->get_mmc_clk(host, freq);
>  	else if (host->bus_hz)
>  		sclk = host->bus_hz;
>  	else {
> diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c
> index cde2ba7..863bbb3 100644
> --- a/drivers/mmc/exynos_dw_mmc.c
> +++ b/drivers/mmc/exynos_dw_mmc.c
> @@ -39,7 +39,7 @@ static void exynos_dwmci_clksel(struct dwmci_host *host)
>  	dwmci_writel(host, DWMCI_CLKSEL, priv->sdr_timing);
>  }
>  
> -unsigned int exynos_dwmci_get_clk(struct dwmci_host *host)
> +unsigned int exynos_dwmci_get_clk(struct dwmci_host *host, uint freq)
>  {
>  	unsigned long sclk;
>  	int8_t clk_div;
> diff --git a/include/dwmmc.h b/include/dwmmc.h
> index 7a7555a..25cf42c 100644
> --- a/include/dwmmc.h
> +++ b/include/dwmmc.h
> @@ -163,7 +163,21 @@ struct dwmci_host {
>  
>  	void (*clksel)(struct dwmci_host *host);
>  	void (*board_init)(struct dwmci_host *host);
> -	unsigned int (*get_mmc_clk)(struct dwmci_host *host);
> +
> +	/**
> +	 * Get / set a particular MMC clock frequency
> +	 *
> +	 * This is used to request the current clock frequency of the clock
> +	 * that drives the DWMMC peripheral. The caller will then use this
> +	 * information to work out the divider it needs to achieve the
> +	 * required MMC bus clock frequency. If you want to handle the
> +	 * clock external to DWMMC, use @freq to select the frequency and
> +	 * return that value too. Then DWMMC will put itself in bypass mode.
> +	 *
> +	 * @host:	DWMMC host
> +	 * @freq:	Frequency the host is trying to achieve
> +	 */
> +	unsigned int (*get_mmc_clk)(struct dwmci_host *host, uint freq);
>  
>  	struct mmc_config cfg;
>  };
> 

  reply	other threads:[~2015-08-25  2:18 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 15:12 [U-Boot] [PATCH v4 00/33] dm: Introduce Rockchip RK3288 support Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 01/33] pinctrl: Correct build errors in the pinctrl_simple Simon Glass
2015-08-24 15:31   ` Simon Glass
2015-08-26  4:16     ` Masahiro Yamada
2015-08-24 15:12 ` [U-Boot] [PATCH v4 02/33] pinctrl: Add help text to Kconfig Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 03/33] pinctrl: Add the concept of peripheral IDs Simon Glass
2015-08-26  4:30   ` Masahiro Yamada
2015-08-26  4:38     ` Simon Glass
2015-08-26  4:51       ` Masahiro Yamada
2015-08-26 13:20         ` Simon Glass
2015-08-27  4:39           ` Masahiro Yamada
2015-08-30 22:45             ` Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 04/33] mmc: Support bypass mode with the get_mmc_clk() method Simon Glass
2015-08-25  2:18   ` Jaehoon Chung [this message]
2015-08-24 15:12 ` [U-Boot] [PATCH v4 05/33] dm: do not return pointer if NULL is given to devp of device_bind() Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 06/33] dm: Improve handling of a missing uclass Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 07/33] dm: Provide better debugging when a device fails to bind Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 08/33] arm: reset: Avoid a build error when the reset uclass is enabled Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 09/33] rockchip: Add serial support Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 10/33] rockchip: Bring in RK3288 device tree file includes and bindings Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 11/33] rockchip: rk3288: dts: Make core devices available early Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 12/33] mkimage: Allow padding to any length Simon Glass
2015-08-25 18:11   ` Joe Hershberger
2015-08-24 15:12 ` [U-Boot] [PATCH v4 13/33] mkimage: Allow the original file size to be recorded Simon Glass
2015-08-25 18:12   ` Joe Hershberger
2015-08-24 15:12 ` [U-Boot] [PATCH v4 14/33] rockchip: Add the rkimage format to mkimage Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 15/33] rockchip: Add support for the SD image Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 16/33] rockchip: Add support for the SPI image Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 17/33] rockchip: gpio: Add rockchip GPIO driver Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 18/33] rockchip: Add basic peripheral and clock definitions Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 19/33] power: Add support for ACT8846 PMIC Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 20/33] power: regulator: Add a driver for ACT8846 regulators Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 21/33] rockchip: rk3288: Add clock driver Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 22/33] rockchip: rk3288: Add header files for PMU and GRF Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 23/33] rockchip: rk3288: Add SoC reset driver Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 24/33] rockchip: rk3288: Add a simple syscon driver Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 25/33] rockchip: rk3288: Add pinctrl driver Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 26/33] rockchip: rk3288: Add SDRAM init Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 27/33] rockchip: Add an MMC driver Simon Glass
2015-08-25  2:31   ` Jaehoon Chung
2015-08-30 22:45     ` Simon Glass
2015-08-25 18:26   ` Andre Przywara
2015-08-30 22:45     ` Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 28/33] rockchip: Add core SoC start-up code Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 29/33] rockchip: Add I2C driver Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 30/33] rockchip: Add SPI driver Simon Glass
2015-08-28  4:42   ` Jagan Teki
2015-08-30 22:45     ` Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 31/33] rockchip: Add basic support for firefly-rk3288 Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 32/33] rockchip: Add basic support for jerry Simon Glass
2015-08-24 15:12 ` [U-Boot] [PATCH v4 33/33] rockchip: Add a simple README Simon Glass
2015-08-24 15:32 ` [U-Boot] [PATCH v4 00/33] dm: Introduce Rockchip RK3288 support Simon Glass
2015-08-30 17:40 ` Sjoerd Simons
2015-08-30 22:45   ` Simon Glass
2015-11-09  8:41 ` cwz at rock-chips.com
2015-11-09 20:24   ` Simon Glass
2015-11-10  2:34     ` cwz at rock-chips.com
2015-11-10 19:25       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DBD074.4010501@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox