From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Tue, 25 Aug 2015 09:18:42 +0200
Subject: [U-Boot] [PATCH 2/4] sunxi_nand_spl: Remove
 NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END
In-Reply-To: <1440435731.30043.26.camel@freescale.com>
References: <1440267221-22220-1-git-send-email-hdegoede@redhat.com>
 <1440267221-22220-2-git-send-email-hdegoede@redhat.com>
 <1440435731.30043.26.camel@freescale.com>
Message-ID: <55DC16D2.804@redhat.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 24-08-15 19:02, Scott Wood wrote:
> On Sat, 2015-08-22 at 20:13 +0200, Hans de Goede wrote:
>> We only ever use syndrome mode for the partitions which contain the SPL,
>> as that is required for the BROM to be able to read the SPL.
>>
>> Instead of using some arbritray limit for deciding whether or not to
>> use syndrome, be smart and check if u-boot-dtb.bin is directly behind
>> the SPL, if it is not then it is on its own partition and we should not
>> use syndrome.
>>
>> Note the reason why we only use syndrome mode is because it comes with
>> weaker randomization,
>
> "...why we only use syndrome mode for the SPL is because..."
>
>>   introducing a risc for more bit errors,
>
> risk

Will fix.

>> -     int syndrome = offs < CONFIG_NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END;
>> -     int i;
>> +     int i, syndrome;
>> +
>> +     if (CONFIG_SYS_NAND_U_BOOT_OFFS == CONFIG_SPL_PAD_TO)
>> +             syndrome = 1; /* u-boot-dtb.bin appended to SPL */
>> +     else
>> +             syndrome = 0; /* u-boot-dtb.bin on its own partition */
>
> Is it not possible for a separate partition to begin at CONFIG_SPL_PAD_TO, or
> would padding not be used in that case?

CONFIG_SPL_PAD_TO always is 32k on sunxi, partitions must be on an eraseblock
boundary and eraseblocks are always much larger then 32k, so this cannot happen.

Regards,

Hans