From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nishanth Menon <nm@ti.com>
Date: Tue, 25 Aug 2015 10:47:00 -0500
Subject: [U-Boot] [PATCH 2/3] remoteproc: Introduce a sandbox dummy
	driver
In-Reply-To: <CAPnjgZ253Q+fGm9x6uVSkYbz6d=7p8jG9A7X3jcic5zjiXuziQ@mail.gmail.com>
References: <1440437317-5178-1-git-send-email-nm@ti.com>
 <1440437317-5178-3-git-send-email-nm@ti.com>
 <CAPnjgZ253Q+fGm9x6uVSkYbz6d=7p8jG9A7X3jcic5zjiXuziQ@mail.gmail.com>
Message-ID: <55DC8DF4.308@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/25/2015 12:04 AM, Simon Glass wrote:
[...]
>> +# Please keep the configuration alphabetically sorted.
>> +config DM_TESTPROC_SANDBOX
> 
> Should this be REMOTEPROC_SANDBOX?

Yep - will do.

>> diff --git a/drivers/remoteproc/sandbox_testproc.c b/drivers/remoteproc/sandbox_testproc.c
>> new file mode 100644
>> index 000000000000..e942f66fc2dc
>> --- /dev/null
>> +++ b/drivers/remoteproc/sandbox_testproc.c
>> @@ -0,0 +1,243 @@
>> +/*
>> + * (C) Copyright 2015
>> + * Texas Instruments Incorporated - http://www.ti.com/
>> + * SPDX-License-Identifier:    GPL-2.0+
>> + */
>> +#define pr_fmt(fmt) "%s: " fmt, __func__
^^

>> +#include <common.h>
>> +#include <dm.h>
>> +#include <errno.h>
>> +#include <remoteproc.h>

[...]

>> +
>> +static int sandbox_testproc_is_running(struct udevice *dev)
>> +{
>> +       struct dm_rproc_uclass_pdata *uc_pdata;
>> +       struct sandbox_test_devdata *ddata;
>> +       int ret = 1;
>> +
>> +       uc_pdata = dev_get_uclass_platdata(dev);
>> +       ddata = dev_get_priv(dev);
>> +
>> +       if (ddata->current_state == sb_running)
>> +               ret = 0;
>> +       debug("%s: called(%d)\n", uc_pdata->name, ret);
> 
> should that say "is_running called" / do you need __func__?

pr_fmt (at the start of the file) should take care of it.

[...]

>> +U_BOOT_DRIVER(sandbox_testproc) = {
>> +       /* *INDENT-OFF* */
> 
> What is that for? ^^

trying to keep indent sane - will drop.


Thanks once again for the review.


-- 
Regards,
Nishanth Menon