From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Ricard Date: Tue, 25 Aug 2015 20:40:30 +0200 Subject: [U-Boot] [PATCH v2 20/28] tpm: Check that parse_byte_string() has data to parse In-Reply-To: References: <1440289904-31280-1-git-send-email-sjg@chromium.org> <1440289904-31280-21-git-send-email-sjg@chromium.org> <55DB7CF3.4010906@gmail.com> Message-ID: <55DCB69E.2070504@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Le 25/08/2015 06:13, Simon Glass a ?crit : > Hi Christophe, > > On 24 August 2015 at 14:22, Christophe Ricard > wrote: >> Hi Simon, >> >> Print an error ? Are you sure ? I guess the comment is not accurate ;). >> > Well returning NULL from parse_byte_string() will cause an error to be > printed by the caller... This is just a comment nitpick. I think it is clear enough but from the patch the printing is may be not so obvious. It is just fine like that. > > Regards, > Simon Best Regards Christophe >> Best Regards >> Christophe >> >> >> On 23/08/2015 02:31, Simon Glass wrote: >>> Rather then crashing when there is no data, print an error. >>> >>> Acked-by: Christophe Ricard >>> Signed-off-by: Simon Glass >>> --- >>> >>> Changes in v2: None >>> >>> common/cmd_tpm.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/common/cmd_tpm.c b/common/cmd_tpm.c >>> index 65e7371..e9c6618 100644 >>> --- a/common/cmd_tpm.c >>> +++ b/common/cmd_tpm.c >>> @@ -58,6 +58,8 @@ static void *parse_byte_string(char *bytes, uint8_t >>> *data, size_t *count_ptr) >>> size_t count, length; >>> int i; >>> + if (!bytes) >>> + return NULL; >>> length = strlen(bytes); >>> count = length / 2; >>> >>