From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 25 Aug 2015 19:59:26 -0600 Subject: [U-Boot] [PATCH] ARM: rpi: Add CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG support In-Reply-To: <1440553602.1313.42.camel@freebsd.org> References: <1439906635-28191-1-git-send-email-guillaume.gardet@free.fr> <55D3F480.5080809@wwwdotorg.org> <55D6F3B3.2000009@free.fr> <55DD17B7.4080206@wwwdotorg.org> <1440553602.1313.42.camel@freebsd.org> Message-ID: <55DD1D7E.5000702@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/25/2015 07:46 PM, Ian Lepore wrote: > On Tue, 2015-08-25 at 19:34 -0600, Stephen Warren wrote: >> On 08/21/2015 03:47 AM, Guillaume Gardet wrote: >>> >>> >>> Le 19/08/2015 05:14, Stephen Warren a ?crit : >>>> On 08/18/2015 08:03 AM, Guillaume GARDET wrote: >>>>> Add CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG support to set 'board_rev' and >>>>> 'board_name' envs. >>>> That states what the patch does rather than why its useful to do it. Can >>>> you expand on why it's useful to set these variables? >>> >>> Using boot scripts you may need to get the board version / revision >>> infos, for example to select the right DTB since u-boot DTB names and >>> kernel DTB files do not match. >> >> The fix here isn't to craft all kinds of complex scripts in U-Boot based >> on a slew of extra variables. Rather, the set of DT files in the kernel >> should be expanded so that there is one DT per board design, i.e. so the >> filenames in the kernel match the filenames that U-Boot expects. > > You speak of "the kernel" as if there were only one. You're right; I should have said "DT file repository" not "kernel" here. In practice, that's the Linux kernel at present though. Still, I stand by my assertion that the values U-Boot expects for DTB filenames make sense, and we should update any/all repositories of DTB files so there is a complete set of matching files.