public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/4] sunxi: nand: Basic NAND driver for SPL
Date: Thu, 27 Aug 2015 12:06:18 +0200	[thread overview]
Message-ID: <55DEE11A.2080305@denx.de> (raw)
In-Reply-To: <55D5E914.40900@denx.de>

Hi Hans,

On 20.08.2015 16:49, Stefan Roese wrote:
>> Yes, see:
>>
>> https://github.com/NextThingCo/CHIP-u-boot
>> https://github.com/jwrdegoede/u-boot-sunxi/commits/sunxi-nand-wip
>
> Thanks.

I've started on your "sunxi-nand-wip" branch. And noticed that its 
currently stuck / hangs in nand_onfi_set_features() called via 
sunxi_nand_chip_init_timings(). I've attached 2 patches now:

One with some whitespace / coding-style fixes and more important a 2nd 
one that actually fixes some buggy pointer initialization.

I just wanted to share this improvement, even if the driver still does 
not work correctly. But at least its not crashing that early with this fix.

Comments welcome.

BTW: What is the current status of this code? From my debugging (see 2nd 
patch) it seems that this should not be good enough to run on any board yet.

Thanks,
Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mtd-nand-sunxi_nand.c-Use-common-struct-mtd-pointer.patch
Type: text/x-diff
Size: 2259 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150827/0bcb34df/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mtd-nand-sunxi_nand.c-Whitespace-cleanup.patch
Type: text/x-diff
Size: 6316 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150827/0bcb34df/attachment-0001.patch>

  reply	other threads:[~2015-08-27 10:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 12:33 [U-Boot] [PATCH v3 0/4] sunxi: nand: Basic NAND driver for SPL Piotr Zierhoffer
2015-07-23 12:33 ` [U-Boot] [PATCH v3 1/4] sunxi: nand: Add pinmux and clock settings for NAND support Piotr Zierhoffer
2015-07-23 12:33 ` [U-Boot] [PATCH v3 2/4] sunxi: nand: Add basic sunxi NAND driver for SPL with DMA support Piotr Zierhoffer
2015-07-31  0:47   ` Scott Wood
2015-07-31  8:36     ` Hans de Goede
2015-07-31  9:24       ` Boris Brezillon
2015-07-31 14:25         ` Michal Suchanek
2015-07-31 14:27           ` Hans de Goede
2015-07-31 14:41           ` Boris Brezillon
2015-07-31 15:27             ` Michal Suchanek
2015-07-31 16:57             ` Scott Wood
2015-07-23 12:33 ` [U-Boot] [PATCH v3 3/4] sunxi: nand: Add board configuration options Piotr Zierhoffer
2015-07-23 12:33 ` [U-Boot] [PATCH v3 4/4] sunxi: nand: Add information to sunxi that it was run from NAND in SPL Piotr Zierhoffer
2015-07-23 14:04 ` [U-Boot] [PATCH v3 0/4] sunxi: nand: Basic NAND driver for SPL Marek Vasut
2015-07-23 14:59   ` Piotr Zierhoffer
2015-07-23 15:57     ` Marek Vasut
2015-08-01 12:15 ` Hans de Goede
2015-08-01 12:30   ` Boris Brezillon
2015-08-01 19:22     ` Scott Wood
2015-08-02 12:56       ` Hans de Goede
2015-08-06  7:55         ` Piotr Zierhoffer
2015-08-20 12:37           ` Stefan Roese
2015-08-20 13:42             ` Hans de Goede
2015-08-20 14:49               ` Stefan Roese
2015-08-27 10:06                 ` Stefan Roese [this message]
2015-08-27 10:10                   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DEE11A.2080305@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox