From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: gadget: ci_udc: implement usb_ep_ops dequeue callback
Date: Thu, 27 Aug 2015 10:06:14 -0600 [thread overview]
Message-ID: <55DF3576.5030308@wwwdotorg.org> (raw)
In-Reply-To: <201508271308.46472.marex@denx.de>
On 08/27/2015 05:08 AM, Marek Vasut wrote:
> On Thursday, August 27, 2015 at 01:00:50 PM, Peng Fan wrote:
>> Implement endpoint dequeue callback function.
>>
>> Without this function, uboot will hang when executing fastboot comamnd.
>> See following flow:
>> "fastboot_tx_write_str->fastboot_tx_write->usb_ep_dequeue->ep->ops->dequeue
>> " without implement ci_udc dequeue function, ep->ops->dequeue is NULL, then
>> uboot will hang.
>>
>> Tested on mx6qsabresd board with fastboot enabled.
>> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
>> +static int ci_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
>> + if (ci_req->req.status == -EINPROGRESS) {
>> + ci_req->req.status = -ECONNRESET;
>> + if (ci_req->req.complete)
>> + ci_req->req.complete(_ep, _req);
>> + }
Is there no need to reprogram the HW to abort the transfer?
next prev parent reply other threads:[~2015-08-27 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 11:00 [U-Boot] [PATCH] usb: gadget: ci_udc: implement usb_ep_ops dequeue callback Peng Fan
2015-08-27 11:08 ` Marek Vasut
2015-08-27 16:06 ` Stephen Warren [this message]
2015-08-28 0:05 ` Peng Fan
2015-08-30 7:26 ` Peng Fan
2015-09-01 19:45 ` Stephen Warren
2015-09-03 22:11 ` Marek Vasut
2015-09-09 2:17 ` Stephen Warren
2015-09-09 3:24 ` Peng Fan
2015-09-09 4:30 ` Peng Fan
2015-09-09 23:20 ` Marek Vasut
2015-08-28 0:02 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DF3576.5030308@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox