public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] mtd: nand: Make CONFIG_SYS_NAND_U_BOOT_OFFS configurable through Kconfig
Date: Thu, 27 Aug 2015 20:04:36 +0200	[thread overview]
Message-ID: <55DF5134.7000401@redhat.com> (raw)
In-Reply-To: <1440616117.16577.127.camel@freescale.com>

Hi,

On 26-08-15 21:08, Scott Wood wrote:
> On Wed, 2015-08-26 at 19:38 +0100, Ian Campbell wrote:
>> On Sat, 2015-08-22 at 20:13 +0200, Hans de Goede wrote:
>>> Make CONFIG_SYS_NAND_U_BOOT_OFFS configurable through Kconfig, just
>>> like
>>> SYS_NAND_BUSWIDTH_16BIT this is only enabled on some SoCs using
>>> depends,
>>> to avoid double defining it for SoCs which have not yet moved to
>>> Kconfig
>>> for this.
>>>
>>> Having this in Kconfig is useful because this is something which may
>>> differ from one board to the other even when using the same SoC.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> For the sunxi side:
>> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>>
>> (But needs MTD custodian's more, I guess that is Scott?)
>
> Acked-by: Scott Wood <scottwood@freescale.com>
>
> ...but note that this is one of the symbols that can never be kconfigized for
> the boards that use TPL, so long as SPLs can't have their own config.

Hmm, maybe we beed to have 2 values for it then:
CONFIG_SYS_NAND_SPL_U_BOOT_OFFS
CONFIG_SYS_NAND_TPL_U_BOOT_OFFS

And select which one to use depending we are building the SPL or the TPL,
then both could go to Kconfig

> I'm also not looking forward to such symbols growing a huge list of boards in
> the depends field.  I'm not sure what the answer is here.

See above, if we do something like that, then at one point in time we
can choose to put in some effort to convert the remaining boards,
and just drop the depends.

Regards,

Hans

  reply	other threads:[~2015-08-27 18:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 18:13 [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXI to NAND_SUNXI Hans de Goede
2015-08-22 18:13 ` [U-Boot] [PATCH 2/4] sunxi_nand_spl: Remove NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END Hans de Goede
2015-08-24 17:02   ` Scott Wood
2015-08-25  7:18     ` Hans de Goede
2015-08-26 18:37       ` Ian Campbell
2015-08-22 18:13 ` [U-Boot] [PATCH 3/4] mtd: nand: Make CONFIG_SYS_NAND_U_BOOT_OFFS configurable through Kconfig Hans de Goede
2015-08-26 18:38   ` Ian Campbell
2015-08-26 19:08     ` Scott Wood
2015-08-27 18:04       ` Hans de Goede [this message]
2015-08-22 18:13 ` [U-Boot] [PATCH 4/4] sunxi: Add inet97fv2_defconfig Hans de Goede
2015-08-26 18:39   ` Ian Campbell
2015-08-27  8:11     ` Hans de Goede
2015-08-27 20:18       ` Ian Campbell
2015-08-26 18:35 ` [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXI to NAND_SUNXI Ian Campbell
2015-09-18 11:43 ` [U-Boot] [PATCH 1/4] sunxi_nand_spl: Rename SPL_NAND_SUNXIto NAND_SUNXI Olliver Schinagl
2015-09-18 11:51   ` Olliver Schinagl
2015-09-20 13:09   ` Hans de Goede
2015-09-26 13:01     ` Olliver Schinagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DF5134.7000401@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox